Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2016)

Unified Diff: android_webview/native/aw_pdf_exporter.cc

Issue 1492703004: Pass method parameters as JavaParamRef in android_webview. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: forgot to test compile unit tests before uploading, whoops Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « android_webview/native/aw_pdf_exporter.h ('k') | android_webview/native/aw_picture.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/native/aw_pdf_exporter.cc
diff --git a/android_webview/native/aw_pdf_exporter.cc b/android_webview/native/aw_pdf_exporter.cc
index 48fa9f991fbf6d830ff74121f6a168b39de43f31..af08f1ff45ef7b44f589debe2bb8a1114a9f5dea 100644
--- a/android_webview/native/aw_pdf_exporter.cc
+++ b/android_webview/native/aw_pdf_exporter.cc
@@ -33,9 +33,9 @@ AwPdfExporter::~AwPdfExporter() {
}
void AwPdfExporter::ExportToPdf(JNIEnv* env,
- jobject obj,
+ const JavaParamRef<jobject>& obj,
int fd,
- jobject cancel_signal) {
+ const JavaParamRef<jobject>& cancel_signal) {
DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
printing::PrintSettings print_settings;
InitPdfSettings(env, obj, print_settings);
« no previous file with comments | « android_webview/native/aw_pdf_exporter.h ('k') | android_webview/native/aw_picture.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698