Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2872)

Unified Diff: android_webview/native/aw_contents_client_bridge_unittest.cc

Issue 1492703004: Pass method parameters as JavaParamRef in android_webview. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: forgot to test compile unit tests before uploading, whoops Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « android_webview/native/aw_contents_client_bridge.cc ('k') | android_webview/native/aw_http_auth_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/native/aw_contents_client_bridge_unittest.cc
diff --git a/android_webview/native/aw_contents_client_bridge_unittest.cc b/android_webview/native/aw_contents_client_bridge_unittest.cc
index 5f19a52adb660b0a461e2897530e2405c128d701..e685d0bf352164aad0e76170fa094b390b6f9ebc 100644
--- a/android_webview/native/aw_contents_client_bridge_unittest.cc
+++ b/android_webview/native/aw_contents_client_bridge_unittest.cc
@@ -129,10 +129,10 @@ TEST_F(AwContentsClientBridgeTest,
bridge_->SelectClientCertificate(
cert_request_info_.get(),
make_scoped_ptr(new TestClientCertificateDelegate(this)));
- bridge_->ProvideClientCertificateResponse(env_, jbridge_.obj(),
+ bridge_->ProvideClientCertificateResponse(
+ env_, jbridge_,
Java_MockAwContentsClientBridge_getRequestId(env_, jbridge_.obj()),
- Java_MockAwContentsClientBridge_createTestCertChain(
- env_, jbridge_.obj()).obj(),
+ Java_MockAwContentsClientBridge_createTestCertChain(env_, jbridge_.obj()),
nullptr);
base::RunLoop().RunUntilIdle();
EXPECT_EQ(nullptr, selected_cert_);
@@ -150,8 +150,8 @@ TEST_F(AwContentsClientBridgeTest,
make_scoped_ptr(new TestClientCertificateDelegate(this)));
int requestId =
Java_MockAwContentsClientBridge_getRequestId(env_, jbridge_.obj());
- bridge_->ProvideClientCertificateResponse(
- env_, jbridge_.obj(), requestId, nullptr, nullptr);
+ bridge_->ProvideClientCertificateResponse(env_, jbridge_, requestId, nullptr,
+ nullptr);
base::RunLoop().RunUntilIdle();
EXPECT_EQ(nullptr, selected_cert_);
EXPECT_EQ(1, cert_selected_callbacks_);
« no previous file with comments | « android_webview/native/aw_contents_client_bridge.cc ('k') | android_webview/native/aw_http_auth_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698