android_webview/native/aw_picture.h - Issue 1492703004: Pass method parameters as JavaParamRef in android_webview.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/native/aw_picture.h

Issue 1492703004: Pass method parameters as JavaParamRef in android_webview. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« android_webview/native/aw_contents_client_bridge_unittest.cc ('K') | « android_webview/native/aw_pdf_exporter.cc ('k') | android_webview/native/aw_picture.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/native/aw_picture.h

diff --git a/android_webview/native/aw_picture.h b/android_webview/native/aw_picture.h

index fc4d1ec86041afccc77a926977c709072f65a6b4..bc129e5db26d73ee30c69a56b3dfda824e985360 100644

--- a/android_webview/native/aw_picture.h

+++ b/android_webview/native/aw_picture.h

@@ -23,10 +23,12 @@ class AwPicture {

~AwPicture();

// Methods called from Java.

- void Destroy(JNIEnv* env, jobject obj);

- jint GetWidth(JNIEnv* env, jobject obj);

- jint GetHeight(JNIEnv* env, jobject obj);

- void Draw(JNIEnv* env, jobject obj, jobject canvas);

+ void Destroy(JNIEnv* env, const base::android::JavaParamRef<jobject>& obj);

+ jint GetWidth(JNIEnv* env, const base::android::JavaParamRef<jobject>& obj);

+ jint GetHeight(JNIEnv* env, const base::android::JavaParamRef<jobject>& obj);

+ void Draw(JNIEnv* env,

+ const base::android::JavaParamRef<jobject>& obj,

+ const base::android::JavaParamRef<jobject>& canvas);

private:

skia::RefPtr<SkPicture> picture_;