android_webview/native/aw_contents_client_bridge_unittest.cc - Issue 1492703004: Pass method parameters as JavaParamRef in android_webview.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/native/aw_contents_client_bridge_unittest.cc

Issue 1492703004: Pass method parameters as JavaParamRef in android_webview. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« android_webview/native/aw_contents_client_bridge.cc ('K') | « android_webview/native/aw_contents_client_bridge.cc ('k') | android_webview/native/aw_http_auth_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/native/aw_contents_client_bridge_unittest.cc

diff --git a/android_webview/native/aw_contents_client_bridge_unittest.cc b/android_webview/native/aw_contents_client_bridge_unittest.cc

index 5f19a52adb660b0a461e2897530e2405c128d701..6ad7c7399149fb94ef529ee7f3012f2778673806 100644

--- a/android_webview/native/aw_contents_client_bridge_unittest.cc

+++ b/android_webview/native/aw_contents_client_bridge_unittest.cc

@@ -129,10 +129,10 @@ TEST_F(AwContentsClientBridgeTest,

bridge_->SelectClientCertificate(

cert_request_info_.get(),

make_scoped_ptr(new TestClientCertificateDelegate(this)));

- bridge_->ProvideClientCertificateResponse(env_, jbridge_.obj(),

+ bridge_->ProvideClientCertificateResponse(

Torne 2015/12/03 14:56:30 manual change here to pass parameters as JavaRef i

+ env_, jbridge_,

Java_MockAwContentsClientBridge_getRequestId(env_, jbridge_.obj()),

- Java_MockAwContentsClientBridge_createTestCertChain(

- env_, jbridge_.obj()).obj(),

+ Java_MockAwContentsClientBridge_createTestCertChain(env_, jbridge_.obj()),

nullptr);

base::RunLoop().RunUntilIdle();

EXPECT_EQ(nullptr, selected_cert_);