Pass method parameters as JavaParamRef in android_webview.

android_webview/native/aw_contents_client_bridge.h

Index: android_webview/native/aw_contents_client_bridge.h
diff --git a/android_webview/native/aw_contents_client_bridge.h b/android_webview/native/aw_contents_client_bridge.h
index 74f13e00403581871b27b2f736df5ebeee2c408f..5372fb07442793cd7fe35c849aca7a2b17ebc95a 100644
--- a/android_webview/native/aw_contents_client_bridge.h
+++ b/android_webview/native/aw_contents_client_bridge.h
@@ -56,12 +56,21 @@ class AwContentsClientBridge : public AwContentsClientBridgeBase {
       override;
 
   // Methods called from Java.
-  void ProceedSslError(JNIEnv* env, jobject obj, jboolean proceed, jint id);
-  void ProvideClientCertificateResponse(JNIEnv* env, jobject object,
-      jint request_id, jobjectArray encoded_chain_ref,
-      jobject private_key_ref);
-  void ConfirmJsResult(JNIEnv*, jobject, int id, jstring prompt);
-  void CancelJsResult(JNIEnv*, jobject, int id);
+  void ProceedSslError(JNIEnv* env,

[Torne, 2015/12/03 14:56:30]

manual change: converted this file directly to JavaRef, to avoid doing horrible
things in the unit test code. JavaParamRef is just an intermediate step in the
migration (it allows implicit conversion back to jobject), so skipping it is
okay, I fixed the relevant code to not rely on the conversion.

[sgurun-gerrit only, 2015/12/03 22:21:38]

I think java_ref is not necessary for anything except
provideclientcertificateresponse. but either way should be ok.

+                       const base::android::JavaRef<jobject>& obj,
+                       jboolean proceed,
+                       jint id);
+  void ProvideClientCertificateResponse(
+      JNIEnv* env,
+      const base::android::JavaRef<jobject>& object,
+      jint request_id,
+      const base::android::JavaRef<jobjectArray>& encoded_chain_ref,
+      const base::android::JavaRef<jobject>& private_key_ref);
+  void ConfirmJsResult(JNIEnv*,
+                       const base::android::JavaRef<jobject>&,
+                       int id,
+                       const base::android::JavaRef<jstring>& prompt);
+  void CancelJsResult(JNIEnv*, const base::android::JavaRef<jobject>&, int id);
 
  private:
   void HandleErrorInClientCertificateResponse(int id);