Pass method parameters as JavaParamRef in android_webview.

android_webview/native/aw_contents_client_bridge.h

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ANDROID_WEBVIEW_NATIVE_AW_CONTENTS_CLIENT_BRIDGE_H_
 #define ANDROID_WEBVIEW_NATIVE_AW_CONTENTS_CLIENT_BRIDGE_H_
 
 #include <jni.h>
 
 #include "android_webview/browser/aw_contents_client_bridge_base.h"
@@ skipping 38 matching lines @@
       const base::string16& default_prompt_text,
       const content::JavaScriptDialogManager::DialogClosedCallback& callback)
       override;
   void RunBeforeUnloadDialog(
       const GURL& origin_url,
       const base::string16& message_text,
       const content::JavaScriptDialogManager::DialogClosedCallback& callback)
       override;
 
   // Methods called from Java.
-  void ProceedSslError(JNIEnv* env, jobject obj, jboolean proceed, jint id);
-  void ProvideClientCertificateResponse(JNIEnv* env, jobject object,
-      jint request_id, jobjectArray encoded_chain_ref,
-      jobject private_key_ref);
-  void ConfirmJsResult(JNIEnv*, jobject, int id, jstring prompt);
-  void CancelJsResult(JNIEnv*, jobject, int id);
+  void ProceedSslError(JNIEnv* env,

[Torne, 2015/12/03 14:56:30]

manual change: converted this file directly to JavaRef, to avoid doing horrible
things in the unit test code. JavaParamRef is just an intermediate step in the
migration (it allows implicit conversion back to jobject), so skipping it is
okay, I fixed the relevant code to not rely on the conversion.

[sgurun-gerrit only, 2015/12/03 22:21:38]

I think java_ref is not necessary for anything except
provideclientcertificateresponse. but either way should be ok.

+                       const base::android::JavaRef<jobject>& obj,
+                       jboolean proceed,
+                       jint id);
+  void ProvideClientCertificateResponse(
+      JNIEnv* env,
+      const base::android::JavaRef<jobject>& object,
+      jint request_id,
+      const base::android::JavaRef<jobjectArray>& encoded_chain_ref,
+      const base::android::JavaRef<jobject>& private_key_ref);
+  void ConfirmJsResult(JNIEnv*,
+                       const base::android::JavaRef<jobject>&,
+                       int id,
+                       const base::android::JavaRef<jstring>& prompt);
+  void CancelJsResult(JNIEnv*, const base::android::JavaRef<jobject>&, int id);
 
  private:
   void HandleErrorInClientCertificateResponse(int id);
 
   JavaObjectWeakGlobalRef java_ref_;
 
   typedef const base::Callback<void(bool)> CertErrorCallback;
   IDMap<CertErrorCallback, IDMapOwnPointer> pending_cert_error_callbacks_;
   IDMap<content::JavaScriptDialogManager::DialogClosedCallback, IDMapOwnPointer>
       pending_js_dialog_callbacks_;
   // |pending_client_cert_request_delegates_| owns its pointers, but IDMap
   // doesn't provide Release, so ownership is managed manually.
   IDMap<content::ClientCertificateDelegate>
       pending_client_cert_request_delegates_;
 };
 
 bool RegisterAwContentsClientBridge(JNIEnv* env);
 
 }  // namespace android_webview
 
 #endif  // ANDROID_WEBVIEW_NATIVE_AW_CONTENTS_CLIENT_BRIDGE_H_