components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLStreamHandler.java - Issue 1492583002: Add HttpUrlConnection backed implementation of CronetEngine.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLStreamHandler.java

Issue 1492583002: Add HttpUrlConnection backed implementation of CronetEngine. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/cronet/android/api/src/org/chromium/net/CronetEngine.java ('K') | « components/cronet/android/java/src/org/chromium/net/CronetUrlRequestContext.java ('k') | components/cronet/android/test/javatests/src/org/chromium/net/CronetTestBase.java » ('j') | components/cronet/android/test/javatests/src/org/chromium/net/CronetTestBase.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLStreamHandler.java

diff --git a/components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLStreamHandler.java b/components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLStreamHandler.java

index 8cf5ea7353c83f05708106dd551ab4dd9d7e0f6f..1a638967ce977313be4e19423547edfd7773f4ca 100644

--- a/components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLStreamHandler.java

+++ b/components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLStreamHandler.java

@@ -44,7 +44,7 @@ class CronetHttpURLStreamHandler extends URLStreamHandler {

* @return an {@link java.net.HttpURLConnection} instance implemented by Cronet.

@Override

- public URLConnection openConnection(URL url, Proxy proxy) {

+ public URLConnection openConnection(URL url, Proxy proxy) throws IOException {

return mCronetEngine.openConnection(url, proxy);

}