components/cronet/android/java/src/org/chromium/net/CronetUrlRequestContext.java - Issue 1492583002: Add HttpUrlConnection backed implementation of CronetEngine.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/java/src/org/chromium/net/CronetUrlRequestContext.java

Issue 1492583002: Add HttpUrlConnection backed implementation of CronetEngine. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/cronet/android/api/src/org/chromium/net/CronetEngine.java ('K') | « components/cronet/android/java/src/org/chromium/net/CronetUrlRequest.java ('k') | components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLStreamHandler.java » ('j') | components/cronet/android/test/javatests/src/org/chromium/net/CronetTestBase.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/java/src/org/chromium/net/CronetUrlRequestContext.java

diff --git a/components/cronet/android/java/src/org/chromium/net/CronetUrlRequestContext.java b/components/cronet/android/java/src/org/chromium/net/CronetUrlRequestContext.java

index e6a337eb07c0a9e826adf7e4efddf2ac3f431b50..bfb4055f30538a9bbc16df2852966c74bed487de 100644

--- a/components/cronet/android/java/src/org/chromium/net/CronetUrlRequestContext.java

+++ b/components/cronet/android/java/src/org/chromium/net/CronetUrlRequestContext.java

@@ -119,15 +119,6 @@ class CronetUrlRequestContext extends CronetEngine {

}

@Override

- public UrlRequest createRequest(String url, UrlRequest.Callback callback, Executor executor) {

- synchronized (mLock) {

- checkHaveAdapter();

- return new CronetUrlRequest(this, mUrlRequestContextAdapter, url,

- UrlRequest.Builder.REQUEST_PRIORITY_MEDIUM, callback, executor);

- }

- @Override

public UrlRequest createRequest(String url, UrlRequest.Callback callback, Executor executor,

@UrlRequest.Builder.RequestPriority int priority) {

synchronized (mLock) {