mojo: Improve crash stack.

mojo: Improve crash stack.

Call base::debug::EnableInProcessStackDumping() just before initializing
the sandbox, so we could cache symbols in all loaded libraries.

BUG=564184
Committed: https://crrev.com/6758eae9b2a83b42ab8f7926b55cded4ddcd0f71
Cr-Commit-Position: refs/heads/master@{#362531}

[Peng, 2015-12-01 19:23:16]

Patchset #1 (id:1) has been deleted

[Peng, 2015-12-01 19:23:50]

penghuang@chromium.org changed reviewers:
+ sky@chromium.org

[Peng, 2015-12-01 19:23:50]

Hi Scott, PTAL. Thanks.

[sky, 2015-12-01 21:27:48]

sky@chromium.org changed reviewers:
+ erg@chromium.org

[sky, 2015-12-01 21:27:48]

LGTM

[Peng, 2015-12-01 21:46:47]

The CQ bit was checked by penghuang@chromium.org

[commit-bot: I haz the power, 2015-12-01 21:48:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1492523002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1492523002/20001

[commit-bot: I haz the power, 2015-12-01 22:24:33]

Committed patchset #1 (id:20001)

[commit-bot: I haz the power, 2015-12-01 22:26:33]

Description was changed from

==========
mojo: Improve crash stack.

Call base::debug::EnableInProcessStackDumping() just before initializing
the sandbox, so we could cache symbols in all loaded libraries.

BUG=564184
==========

to

==========
mojo: Improve crash stack.

Call base::debug::EnableInProcessStackDumping() just before initializing
the sandbox, so we could cache symbols in all loaded libraries.

BUG=564184

Committed: https://crrev.com/6758eae9b2a83b42ab8f7926b55cded4ddcd0f71
Cr-Commit-Position: refs/heads/master@{#362531}
==========

[commit-bot: I haz the power, 2015-12-01 22:26:34]

Patchset 1 (id:??) landed as
https://crrev.com/6758eae9b2a83b42ab8f7926b55cded4ddcd0f71
Cr-Commit-Position: refs/heads/master@{#362531}

[sadrul, 2015-12-03 18:15:51]

sadrul@chromium.org changed reviewers:
+ sadrul@chromium.org

[sadrul, 2015-12-03 18:15:51]

https://codereview.chromium.org/1492523002/diff/20001/mojo/runner/desktop/mai...
File mojo/runner/desktop/main_helper.cc (left):

https://codereview.chromium.org/1492523002/diff/20001/mojo/runner/desktop/mai...
mojo/runner/desktop/main_helper.cc:45:
base::debug::EnableInProcessStackDumping();
Remove this caused no backtrace when mus crashes. That's a regression :( Can
this remain in place?

[jam, 2015-12-08 20:35:29]

This also broke Windows.

[Peng, 2015-12-08 20:38:21]

On 2015/12/08 20:35:29, jam wrote:
> This also broke Windows.

What do you mean? The StackTrace() doesn't work on Windows for mus process, or a
crash happens.

[jam, 2015-12-08 21:58:07]

On 2015/12/08 20:38:21, Peng wrote:
> On 2015/12/08 20:35:29, jam wrote:
> > This also broke Windows.
> 
> What do you mean? The StackTrace() doesn't work on Windows for mus process, or
a
> crash happens.

stack traces don't show up in both mojo's main runner process, and also child
processes (like mus).

i have a fix for this in https://codereview.chromium.org/1508053003

[chromium-reviews, 2015-12-09 00:39:27]

Thanks for taking care of the issue.

On Tue, Dec 8, 2015 at 4:58 PM, <jam@chromium.org> wrote:

> On 2015/12/08 20:38:21, Peng wrote:
>
>> On 2015/12/08 20:35:29, jam wrote:
>> > This also broke Windows.
>>
>
> What do you mean? The StackTrace() doesn't work on Windows for mus
>> process, or
>>
> a
>
>> crash happens.
>>
>
> stack traces don't show up in both mojo's main runner process, and also
> child
> processes (like mus).
>
> i have a fix for this in https://codereview.chromium.org/1508053003
>
> https://codereview.chromium.org/1492523002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.