Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 1508053003: Show the callstack that a nontransferable message pipe was first used if it's erroneously sent later (Closed)

Created:
5 years ago by jam
Modified:
5 years ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Show the callstack that a nontransferable message pipe was first used if it's erroneously sent later. Also restore display of callstacks on Windows and in POSIX's launcher process. BUG=556259, 564184 Committed: https://crrev.com/b6e0981a8624e7a62d5ff711d20a76693dcdae9d Cr-Commit-Position: refs/heads/master@{#363896}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : remove frame fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -23 lines) Patch
M mojo/edk/system/message_pipe_dispatcher.h View 1 4 chunks +9 lines, -2 lines 0 comments Download
M mojo/edk/system/message_pipe_dispatcher.cc View 1 4 chunks +15 lines, -8 lines 0 comments Download
M mojo/message_pump/handle_watcher.cc View 1 2 2 chunks +12 lines, -0 lines 0 comments Download
M mojo/runner/android/main.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M mojo/runner/desktop/launcher_process.cc View 1 2 chunks +4 lines, -0 lines 0 comments Download
M mojo/runner/desktop/main_helper.cc View 1 1 chunk +1 line, -3 lines 0 comments Download
M mojo/runner/host/child_process.cc View 1 1 chunk +5 lines, -6 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
jam
5 years ago (2015-12-08 22:08:01 UTC) #3
sky
LGTM
5 years ago (2015-12-08 23:08:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1508053003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1508053003/40001
5 years ago (2015-12-08 23:49:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1508053003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1508053003/40001
5 years ago (2015-12-09 00:14:55 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-12-09 01:55:06 UTC) #13
commit-bot: I haz the power
5 years ago (2015-12-09 01:56:30 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b6e0981a8624e7a62d5ff711d20a76693dcdae9d
Cr-Commit-Position: refs/heads/master@{#363896}

Powered by Google App Engine
This is Rietveld 408576698