Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(649)

Issue 1492323003: Updates shadow when active window changes (Closed)

Created:
5 years ago by sky
Modified:
5 years ago
CC:
chromium-reviews, rjkroege, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, kalyank, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Updates shadow when active window changes BUG=548424 TEST=none R=ben@chromium.org Committed: https://crrev.com/0b7f0fb1935725421b7bc35246d10b68e6dae6e2 Cr-Commit-Position: refs/heads/master@{#363125}

Patch Set 1 #

Patch Set 2 : cleanup #

Patch Set 3 : cleanup #

Patch Set 4 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+191 lines, -3 lines) Patch
M components/mus/public/cpp/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/mus/public/cpp/lib/window_tree_client_impl.h View 3 chunks +5 lines, -0 lines 0 comments Download
M components/mus/public/cpp/lib/window_tree_client_impl.cc View 4 chunks +17 lines, -0 lines 0 comments Download
M components/mus/public/cpp/window_observer.h View 1 chunk +1 line, -2 lines 0 comments Download
M components/mus/public/cpp/window_tree_connection.h View 2 chunks +4 lines, -0 lines 0 comments Download
A components/mus/public/cpp/window_tree_connection_observer.h View 1 chunk +23 lines, -0 lines 0 comments Download
M mash/wm/BUILD.gn View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M mash/wm/non_client_frame_controller.cc View 1 chunk +2 lines, -1 line 0 comments Download
M mash/wm/property_util.h View 2 chunks +5 lines, -0 lines 0 comments Download
M mash/wm/property_util.cc View 2 chunks +14 lines, -0 lines 0 comments Download
A mash/wm/shadow_controller.h View 1 chunk +44 lines, -0 lines 0 comments Download
A mash/wm/shadow_controller.cc View 1 1 chunk +66 lines, -0 lines 0 comments Download
M mash/wm/window_manager_application.h View 1 2 3 2 chunks +3 lines, -0 lines 0 comments Download
M mash/wm/window_manager_application.cc View 1 2 3 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
sky
5 years ago (2015-12-03 23:12:02 UTC) #1
Ben Goodger (Google)
lgtm
5 years ago (2015-12-03 23:29:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1492323003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1492323003/60001
5 years ago (2015-12-04 00:40:02 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) android_chromium_gn_compile_dbg on ...
5 years ago (2015-12-04 02:47:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1492323003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1492323003/60001
5 years ago (2015-12-04 03:51:12 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years ago (2015-12-04 04:09:59 UTC) #10
commit-bot: I haz the power
5 years ago (2015-12-04 04:10:48 UTC) #12
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/0b7f0fb1935725421b7bc35246d10b68e6dae6e2
Cr-Commit-Position: refs/heads/master@{#363125}

Powered by Google App Engine
This is Rietveld 408576698