Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 1492273003: Remove gaelogger from luci-go (Closed)

Created:
5 years ago by iannucci
Modified:
5 years ago
Reviewers:
dnj, Vadim Sh., estaab
CC:
andrew.wang, chromium-reviews, infra-reviews+luci-go_chromium.org, M-A Ruel, tandrii+luci-go_chromium.org, todd
Base URL:
https://github.com/luci/luci-go@master
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Remove gaelogger from luci-go Counterpart to https://codereview.chromium.org/1498963003. prod.Use now implements luci-go/common/logging. R=vadimsh@chromium.org, dnj@chromium.org, estaab@chromium.org BUG=https://github.com/luci/gae/issues/22 Committed: https://github.com/luci/luci-go/commit/ac20e5654cce81e37ca7dd88896a3aa9a88fda48

Patch Set 1 #

Total comments: 2

Patch Set 2 : rm memlogger #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -82 lines) Patch
D appengine/gaelogger/doc.go View 1 chunk +0 lines, -9 lines 0 comments Download
D appengine/gaelogger/logger.go View 1 chunk +0 lines, -67 lines 0 comments Download
M appengine/gaemiddleware/context.go View 3 chunks +0 lines, -3 lines 0 comments Download
M appengine/gaetesting/middleware.go View 1 3 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
iannucci
5 years ago (2015-12-04 04:05:22 UTC) #1
Vadim Sh.
lgtm with one addition (or rather deletion) https://codereview.chromium.org/1492273003/diff/1/appengine/gaemiddleware/context.go File appengine/gaemiddleware/context.go (left): https://codereview.chromium.org/1492273003/diff/1/appengine/gaemiddleware/context.go#oldcode48 appengine/gaemiddleware/context.go:48: c = ...
5 years ago (2015-12-04 05:02:40 UTC) #2
iannucci
https://chromiumcodereview.appspot.com/1492273003/diff/1/appengine/gaemiddleware/context.go File appengine/gaemiddleware/context.go (left): https://chromiumcodereview.appspot.com/1492273003/diff/1/appengine/gaemiddleware/context.go#oldcode48 appengine/gaemiddleware/context.go:48: c = gaelogger.Use(c) On 2015/12/04 at 05:02:40, Vadim Sh. ...
5 years ago (2015-12-04 20:09:00 UTC) #3
Vadim Sh.
lgtm
5 years ago (2015-12-04 20:09:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1492273003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1492273003/20001
5 years ago (2015-12-04 20:12:52 UTC) #6
iannucci
On 2015/12/04 at 20:12:52, commit-bot wrote: > CQ is trying da patch. Follow status at ...
5 years ago (2015-12-04 20:13:26 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: Luci-go Mac Tester on master.tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Luci-go%20Mac%20Tester/builds/215)
5 years ago (2015-12-04 20:14:22 UTC) #9
iannucci
5 years ago (2015-12-04 20:22:41 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
ac20e5654cce81e37ca7dd88896a3aa9a88fda48 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698