Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 1498963003: Move gaelogging from luci/luci-go to luci/gae (Closed)

Created:
5 years ago by iannucci
Modified:
5 years ago
Reviewers:
dnj, Vadim Sh., estaab
CC:
chromium-reviews, infra-reviews+luci-gae_chromium.org
Base URL:
https://github.com/luci/gae.git@master
Target Ref:
refs/heads/master
Project:
luci-gae
Visibility:
Public.

Description

Move gaelogging from luci/luci-go to luci/gae Also makes impl/memory Use memlogger too for consistency. This change is required to make luci-go logging work on appengine due to 3a50526e08194bd66487c7c03cccd2108c236468. R=dnj@chromium.org, estaab@chromium.org, vadimsh@chromium.org BUG=https://github.com/luci/gae/issues/22 Committed: https://github.com/luci/gae/commit/b477d21d8b294002993bd96616aa551f3d0f05cf

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -7 lines) Patch
M impl/memory/context.go View 1 3 chunks +10 lines, -6 lines 0 comments Download
M impl/prod/context.go View 1 2 chunks +3 lines, -1 line 0 comments Download
M impl/prod/everything_test.go View 1 2 chunks +5 lines, -0 lines 0 comments Download
A impl/prod/logger.go View 1 chunk +67 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
iannucci
5 years ago (2015-12-04 03:43:43 UTC) #1
dnj
lgtm
5 years ago (2015-12-04 04:32:44 UTC) #2
Vadim Sh.
lgtm
5 years ago (2015-12-04 05:00:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1498963003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1498963003/40001
5 years ago (2015-12-04 20:07:31 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-04 20:12:19 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://github.com/luci/gae/commit/b477d21d8b294002993bd96616aa551f3d0f05cf

Powered by Google App Engine
This is Rietveld 408576698