Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1495543003: Wire up resource cache stats dumping in nanobench (Closed)

Created:
5 years ago by joshua.litt
Modified:
5 years ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Wire up resource cache stats dumping in nanobench TBR=bsalomon@google.com BUG=skia: Committed: https://skia.googlesource.com/skia/+/dc5685ac3752e90dd68179e9f1675ff6f15ed600

Patch Set 1 #

Total comments: 4

Patch Set 2 : feedback inc #

Patch Set 3 : fix windows warnings #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -1 line) Patch
M bench/SKPBench.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M include/gpu/GrContext.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/gpu/GrResourceCache.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/gpu/GrTest.cpp View 1 2 2 chunks +24 lines, -0 lines 0 comments Download

Messages

Total messages: 24 (12 generated)
joshualitt
ptal
5 years ago (2015-12-02 19:07:26 UTC) #2
joshualitt
adding Robert to expedite
5 years ago (2015-12-02 20:39:42 UTC) #4
robertphillips
https://codereview.chromium.org/1495543003/diff/1/src/gpu/GrTest.cpp File src/gpu/GrTest.cpp (right): https://codereview.chromium.org/1495543003/diff/1/src/gpu/GrTest.cpp#newcode233 src/gpu/GrTest.cpp:233: Would it make sense for all these to have ...
5 years ago (2015-12-02 21:02:13 UTC) #5
joshualitt
feedback inc https://codereview.chromium.org/1495543003/diff/1/src/gpu/GrTest.cpp File src/gpu/GrTest.cpp (right): https://codereview.chromium.org/1495543003/diff/1/src/gpu/GrTest.cpp#newcode233 src/gpu/GrTest.cpp:233: On 2015/12/02 21:02:13, robertphillips wrote: > Would ...
5 years ago (2015-12-02 21:28:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1495543003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1495543003/20001
5 years ago (2015-12-02 21:42:42 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/4347)
5 years ago (2015-12-02 21:43:53 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1495543003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1495543003/20001
5 years ago (2015-12-02 21:44:24 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_64-Debug-Trybot/builds/4617)
5 years ago (2015-12-02 21:46:43 UTC) #16
robertphillips
lgtm
5 years ago (2015-12-02 21:54:29 UTC) #17
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1495543003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1495543003/40001
5 years ago (2015-12-02 21:54:42 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1495543003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1495543003/40001
5 years ago (2015-12-02 21:58:02 UTC) #22
commit-bot: I haz the power
5 years ago (2015-12-02 22:08:29 UTC) #24
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/dc5685ac3752e90dd68179e9f1675ff6f15ed600

Powered by Google App Engine
This is Rietveld 408576698