Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 149213003: Cleanup: Fix some lint/style errors in extensions code. (Closed)

Created:
6 years, 10 months ago by Lei Zhang
Modified:
6 years, 10 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, chromium-apps-reviews_chromium.org, darin-cc_chromium.org, jam, extensions-reviews_chromium.org
Visibility:
Public.

Description

Cleanup: Fix some lint/style errors in extensions code. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247680

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -44 lines) Patch
M chrome/browser/extensions/api/content_settings/content_settings_store.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/content_settings/content_settings_store_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/declarative_content/content_condition.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/declarative_content/content_condition_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/api/permissions/permissions_api.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/push_messaging/push_messaging_api.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/tabs/tabs_constants.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_tab_util.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/mime_types_handler.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/common/extensions/mime_types_handler.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/renderer/extensions/media_galleries_custom_bindings.cc View 1 chunk +3 lines, -12 lines 0 comments Download
M chrome/renderer/extensions/send_request_natives.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/resources/extensions/app_window_custom_bindings.js View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/resources/extensions/media_galleries_custom_bindings.js View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/renderer/resources/extensions/permissions_custom_bindings.js View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/browser/extension_prefs.cc View 3 chunks +3 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Lei Zhang
I saved up a lot of other nitpicks along the way while reading extensions code. ...
6 years, 10 months ago (2014-01-29 03:26:07 UTC) #1
not at google - send to devlin
lgtm, thanks :)
6 years, 10 months ago (2014-01-29 04:48:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/149213003/60001
6 years, 10 months ago (2014-01-29 06:19:01 UTC) #3
commit-bot: I haz the power
Retried try job too often on android_aosp for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_aosp&number=42954
6 years, 10 months ago (2014-01-29 08:54:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/149213003/60001
6 years, 10 months ago (2014-01-29 10:43:55 UTC) #5
commit-bot: I haz the power
6 years, 10 months ago (2014-01-29 12:10:34 UTC) #6
Message was sent while issue was closed. 
Change committed as 247680

Powered by Google App Engine
This is Rietveld 408576698