Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Unified Diff: chrome/renderer/extensions/media_galleries_custom_bindings.cc

Issue 149213003: Cleanup: Fix some lint/style errors in extensions code. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/mime_types_handler.cc ('k') | chrome/renderer/extensions/send_request_natives.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/extensions/media_galleries_custom_bindings.cc
===================================================================
--- chrome/renderer/extensions/media_galleries_custom_bindings.cc (revision 247534)
+++ chrome/renderer/extensions/media_galleries_custom_bindings.cc (working copy)
@@ -19,20 +19,11 @@
// FileSystemObject GetMediaFileSystem(string file_system_url): construct
// a file system object from a file system url.
void GetMediaFileSystemObject(const v8::FunctionCallbackInfo<v8::Value>& args) {
- if (args.Length() != 1) {
- NOTREACHED();
- return;
- }
- if (!args[0]->IsString()) {
- NOTREACHED();
- return;
- }
+ CHECK_EQ(1, args.Length());
+ CHECK(args[0]->IsString());
std::string fsid(*v8::String::Utf8Value(args[0]));
- if (fsid.empty()) {
- NOTREACHED();
- return;
- }
+ CHECK(!fsid.empty());
blink::WebFrame* webframe = blink::WebFrame::frameForCurrentContext();
const GURL origin = GURL(webframe->document().securityOrigin().toString());
« no previous file with comments | « chrome/common/extensions/mime_types_handler.cc ('k') | chrome/renderer/extensions/send_request_natives.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698