Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 149193: Add some test for isolated worlds. These tests don't run properly at the mom... (Closed)

Created:
11 years, 5 months ago by abarth-chromium
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Add test harness for isolated worlds. Actual tests will appear upstream. R=dglazkov BUG=15989 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20122

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+415 lines, -1 line) Patch
A webkit/data/layout_tests/chrome/http/tests/security/isolatedWorld/all-window-properties.html View 1 chunk +26 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/chrome/http/tests/security/isolatedWorld/all-window-prototypes.html View 1 chunk +26 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/chrome/http/tests/security/isolatedWorld/body-properties.html View 1 chunk +14 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/chrome/http/tests/security/isolatedWorld/body-prototype.html View 1 chunk +14 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/chrome/http/tests/security/isolatedWorld/document-properties.html View 1 chunk +14 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/chrome/http/tests/security/isolatedWorld/document-prototype.html View 1 chunk +14 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/chrome/http/tests/security/isolatedWorld/global-variables.html View 1 chunk +14 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/chrome/http/tests/security/isolatedWorld/iframe-all-window-properties.html View 1 chunk +29 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/chrome/http/tests/security/isolatedWorld/iframe-all-window-prototype.html View 1 chunk +29 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/chrome/http/tests/security/isolatedWorld/iframe-body-properties.html View 1 chunk +15 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/chrome/http/tests/security/isolatedWorld/iframe-body-prototype.html View 1 chunk +15 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/chrome/http/tests/security/isolatedWorld/iframe-document-properties.html View 1 chunk +15 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/chrome/http/tests/security/isolatedWorld/iframe-document-prototype.html View 1 chunk +15 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/chrome/http/tests/security/isolatedWorld/iframe-location-properites.html View 1 chunk +15 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/chrome/http/tests/security/isolatedWorld/iframe-location-prototype.html View 1 chunk +15 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/chrome/http/tests/security/isolatedWorld/iframe-window-properties.html View 1 chunk +15 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/chrome/http/tests/security/isolatedWorld/location-properties.html View 1 chunk +14 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/chrome/http/tests/security/isolatedWorld/location-prototype.html View 1 chunk +14 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/chrome/http/tests/security/isolatedWorld/number-prototype.html View 1 chunk +14 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/chrome/http/tests/security/isolatedWorld/object-prototype.html View 1 chunk +14 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/chrome/http/tests/security/isolatedWorld/string-prototype.html View 1 chunk +14 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/chrome/http/tests/security/isolatedWorld/window-properties.html View 1 chunk +14 lines, -0 lines 0 comments Download
M webkit/tools/layout_tests/test_expectations.txt View 1 chunk +25 lines, -1 line 0 comments Download
M webkit/tools/test_shell/layout_test_controller.h View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/tools/test_shell/layout_test_controller.cc View 1 3 chunks +20 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
abarth-chromium
11 years, 5 months ago (2009-07-06 08:45:39 UTC) #1
dglazkov
:( We don't need to be adding tests to our tree. But since they've been ...
11 years, 5 months ago (2009-07-06 15:35:10 UTC) #2
abarth-chromium
On 2009/07/06 15:35:10, Dimitri Glazkov wrote: > :( We don't need to be adding tests ...
11 years, 5 months ago (2009-07-06 16:59:15 UTC) #3
dglazkov
LGTM.
11 years, 5 months ago (2009-07-06 17:42:37 UTC) #4
darin (slow to review)
This sucks. We are going to have to move these upstream eventually. I don't really ...
11 years, 5 months ago (2009-07-06 18:37:15 UTC) #5
abarth-chromium
11 years, 5 months ago (2009-07-07 06:27:11 UTC) #6 
Looks like they agreed to take the tests.  I'll land the test_shell changes and
upstream the tests slowly as I can get them to pass.

Powered by Google App Engine
This is Rietveld 408576698