MD Downloads: add a JS unit test for search term splitting

MD Downloads: add a JS unit test for search term splitting

R=dpapad@chromium.org
BUG=563357
Committed: https://crrev.com/7ef0874d0f06cab6555b10b4be4eee8c8bff7f7d
Cr-Commit-Position: refs/heads/master@{#367461}

Committed: https://crrev.com/f41a85116365a8556678961c7904f3bca8c28324
Cr-Commit-Position: refs/heads/master@{#367651}

[dpapad, 2015-12-03 01:19:41]

lgtm

https://codereview.chromium.org/1491773002/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_downloads/action_service_unittest.gtestjs
(right):

https://codereview.chromium.org/1491773002/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_downloads/action_service_unittest.gtestjs:30: var
ActionService = downloads.ActionService;
Nit (optional): You can reduce repetition as follows

var testCases = [
  {expected: [], terms: ''},
  {expected: [], terms: ' '},
  {expected: ['a'], terms: 'a'},
  ...
  ...
];
testCases.forEach(function(testCase) {
  assertEquals(str(testCase.expected), testCase.terms);
});

https://codereview.chromium.org/1491773002/diff/1/chrome/chrome_tests_unit.gypi
File chrome/chrome_tests_unit.gypi (right):

https://codereview.chromium.org/1491773002/diff/1/chrome/chrome_tests_unit.gy...
chrome/chrome_tests_unit.gypi:2303: # TODO(scr): Use this in browser_tests too.
Is this TODO relevant anymore?

[Dan Beam, 2015-12-11 08:17:21]

dbeam@chromium.org changed reviewers:
+ maruel@chromium.org

[Dan Beam, 2015-12-11 08:17:22]

+maruel for isolate stamp

https://codereview.chromium.org/1491773002/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_downloads/action_service_unittest.gtestjs
(right):

https://codereview.chromium.org/1491773002/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_downloads/action_service_unittest.gtestjs:30: var
ActionService = downloads.ActionService;
On 2015/12/03 01:19:41, dpapad wrote:
> Nit (optional): You can reduce repetition as follows
> 
> var testCases = [
>   {expected: [], terms: ''},
>   {expected: [], terms: ' '},
>   {expected: ['a'], terms: 'a'},
>   ...
>   ...
> ];
> testCases.forEach(function(testCase) {
>   assertEquals(str(testCase.expected), testCase.terms);
> });

meh, more lines, more indirection

https://codereview.chromium.org/1491773002/diff/1/chrome/chrome_tests_unit.gypi
File chrome/chrome_tests_unit.gypi (right):

https://codereview.chromium.org/1491773002/diff/1/chrome/chrome_tests_unit.gy...
chrome/chrome_tests_unit.gypi:2303: # TODO(scr): Use this in browser_tests too.
On 2015/12/03 01:19:41, dpapad wrote:
> Is this TODO relevant anymore?

Done.

[M-A Ruel, 2015-12-11 15:15:22]

Shouldn't you have to update BUILD.gn? I'm surprised this didn't fail on linux.

[Dan Beam, 2015-12-11 22:22:13]

On 2015/12/11 15:15:22, M-A Ruel wrote:
> Shouldn't you have to update BUILD.gn? I'm surprised this didn't fail on
linux.

Done.

[dsbeam, 2015-12-15 02:04:56]

dsbeam@gmail.com changed reviewers:
+ dsbeam@gmail.com

[dsbeam, 2015-12-15 02:04:56]

ping, cq if lgty

[M-A Ruel, 2015-12-15 02:07:18]

The CQ bit was checked by maruel@chromium.org

[M-A Ruel, 2015-12-15 02:07:18]

lgtm

[M-A Ruel, 2015-12-15 02:07:18]

The patchset sent to the CQ was uploaded after l-g-t-m from dpapad@chromium.org
Link to the patchset: https://codereview.chromium.org/1491773002/#ps140001
(title: "simpler")

[commit-bot: I haz the power, 2015-12-15 02:11:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1491773002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1491773002/140001

[commit-bot: I haz the power, 2015-12-15 04:23:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-15 04:23:55]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  android_clang_dbg_recipe on tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  android_compile_dbg on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  chromium_presubmit on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  linux_android_rel_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)

[dsbeam, 2015-12-15 07:54:13]

dsbeam@gmail.com changed reviewers:
+ brettw@chromium.org
- dsbeam@gmail.com

[dsbeam, 2015-12-15 07:54:13]

+brettw for chrome/test/BUILD.gn OWNERS

[brettw, 2015-12-30 00:05:27]

lgtm

[Dan Beam, 2015-12-30 00:08:46]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2015-12-30 00:09:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1491773002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1491773002/140001

[commit-bot: I haz the power, 2015-12-30 02:03:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-30 02:03:57]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Dan Beam, 2016-01-05 01:18:19]

The CQ bit was checked by dbeam@chromium.org

[Dan Beam, 2016-01-05 01:18:19]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org,
maruel@chromium.org, dpapad@chromium.org
Link to the patchset: https://codereview.chromium.org/1491773002/#ps240001
(title: "such merges, many conflicts")

[commit-bot: I haz the power, 2016-01-05 01:19:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1491773002/240001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1491773002/240001

[commit-bot: I haz the power, 2016-01-05 02:26:40]

Committed patchset #13 (id:240001)

[commit-bot: I haz the power, 2016-01-05 02:27:33]

Description was changed from

==========
MD Downloads: add a JS unit test for search term splitting

R=dpapad@chromium.org
BUG=563357
==========

to

==========
MD Downloads: add a JS unit test for search term splitting

R=dpapad@chromium.org
BUG=563357

Committed: https://crrev.com/7ef0874d0f06cab6555b10b4be4eee8c8bff7f7d
Cr-Commit-Position: refs/heads/master@{#367461}
==========

[commit-bot: I haz the power, 2016-01-05 02:27:35]

Patchset 13 (id:??) landed as
https://crrev.com/7ef0874d0f06cab6555b10b4be4eee8c8bff7f7d
Cr-Commit-Position: refs/heads/master@{#367461}

[PEConn, 2016-01-05 13:36:14]

A revert of this CL (patchset #13 id:240001) has been created in
https://codereview.chromium.org/1557323003/ by peconn@chromium.org.

The reason for reverting is: I believe this change to be causing issue 574354..

[PEConn, 2016-01-05 16:40:47]

peconn@chromium.org changed reviewers:
+ peconn@chromium.org

[PEConn, 2016-01-05 16:40:48]

This was causing:

https://code.google.com/p/chromium/issues/detail?id=574354

I rolled it back with:

https://codereview.chromium.org/1557323003/

[Dan Beam, 2016-01-05 20:16:33]

Description was changed from

==========
MD Downloads: add a JS unit test for search term splitting

R=dpapad@chromium.org
BUG=563357

Committed: https://crrev.com/7ef0874d0f06cab6555b10b4be4eee8c8bff7f7d
Cr-Commit-Position: refs/heads/master@{#367461}
==========

to

==========
MD Downloads: add a JS unit test for search term splitting

R=dpapad@chromium.org
BUG=563357

Committed: https://crrev.com/7ef0874d0f06cab6555b10b4be4eee8c8bff7f7d
Cr-Commit-Position: refs/heads/master@{#367461}
==========

[Dan Beam, 2016-01-05 20:17:00]

take 3!

[Dan Beam, 2016-01-05 20:17:03]

The CQ bit was checked by dbeam@chromium.org

[Dan Beam, 2016-01-05 20:17:04]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org,
maruel@chromium.org, dpapad@chromium.org
Link to the patchset: https://codereview.chromium.org/1491773002/#ps260001
(title: "exclude some dirs from Android's watchful isolate eyes")

[commit-bot: I haz the power, 2016-01-05 20:18:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1491773002/260001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1491773002/260001

[commit-bot: I haz the power, 2016-01-05 21:35:52]

Description was changed from

==========
MD Downloads: add a JS unit test for search term splitting

R=dpapad@chromium.org
BUG=563357

Committed: https://crrev.com/7ef0874d0f06cab6555b10b4be4eee8c8bff7f7d
Cr-Commit-Position: refs/heads/master@{#367461}
==========

to

==========
MD Downloads: add a JS unit test for search term splitting

R=dpapad@chromium.org
BUG=563357

Committed: https://crrev.com/7ef0874d0f06cab6555b10b4be4eee8c8bff7f7d
Cr-Commit-Position: refs/heads/master@{#367461}
==========

[commit-bot: I haz the power, 2016-01-05 21:35:53]

Committed patchset #14 (id:260001)

[commit-bot: I haz the power, 2016-01-05 21:36:32]

Description was changed from

==========
MD Downloads: add a JS unit test for search term splitting

R=dpapad@chromium.org
BUG=563357

Committed: https://crrev.com/7ef0874d0f06cab6555b10b4be4eee8c8bff7f7d
Cr-Commit-Position: refs/heads/master@{#367461}
==========

to

==========
MD Downloads: add a JS unit test for search term splitting

R=dpapad@chromium.org
BUG=563357

Committed: https://crrev.com/7ef0874d0f06cab6555b10b4be4eee8c8bff7f7d
Cr-Commit-Position: refs/heads/master@{#367461}

Committed: https://crrev.com/f41a85116365a8556678961c7904f3bca8c28324
Cr-Commit-Position: refs/heads/master@{#367651}
==========

[commit-bot: I haz the power, 2016-01-05 21:36:33]

Patchset 14 (id:??) landed as
https://crrev.com/f41a85116365a8556678961c7904f3bca8c28324
Cr-Commit-Position: refs/heads/master@{#367651}