MD Downloads: add a JS unit test for search term splitting

chrome/browser/resources/md_downloads/action_service_unittest.gtestjs

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+/**
+ * @param {!Array<string>} list
+ * @return {string}
+ */
+function str(list) {
+  return JSON.stringify(list);
+}
+
+/**
+ * @extends {testing.Test}
+ * @constructor
+ */
+function ActionServiceUnitTest() {}
+
+ActionServiceUnitTest.prototype = {
+  __proto__: testing.Test.prototype,
+
+  /** @override */
+  extraLibraries: [
+    '../../../../ui/webui/resources/js/cr.js',
+    'action_service.js',
+  ],
+};
+
+TEST_F('ActionServiceUnitTest', 'splitTerms', function() {
+  var ActionService = downloads.ActionService;

[dpapad, 2015/12/03 01:19:41]

Nit (optional): You can reduce repetition as follows

var testCases = [
  {expected: [], terms: ''},
  {expected: [], terms: ' '},
  {expected: ['a'], terms: 'a'},
  ...
  ...
];
testCases.forEach(function(testCase) {
  assertEquals(str(testCase.expected), testCase.terms);
});

[Dan Beam, 2015/12/11 08:17:22]

meh, more lines, more indirection

+  assertEquals(str([]), str(ActionService.splitTerms('')));
+  assertEquals(str([]), str(ActionService.splitTerms('  ')));
+  assertEquals(str(['a']), str(ActionService.splitTerms('a')));
+  assertEquals(str(['a b']), str(ActionService.splitTerms('a b')));
+  assertEquals(str(['a', 'b']), str(ActionService.splitTerms('a "b"')));
+  assertEquals(str(['a', 'b', 'c']), str(ActionService.splitTerms('a "b" c')));
+});