src/debug/liveedit.h - Issue 1491743005: [debugger] do not predict step in target for liveedit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/debug/liveedit.h

Issue 1491743005: [debugger] do not predict step in target for liveedit. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@liveeditstep

Patch Set: do not prepare stepping if we are not in the debugger Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/debug/liveedit.h

diff --git a/src/debug/liveedit.h b/src/debug/liveedit.h

index bc06baff8060f75d51495c4ec121b2a91e12a4d7..f3d6c54c0ed98dff838cd4a7123263c2d40a3f2a 100644

--- a/src/debug/liveedit.h

+++ b/src/debug/liveedit.h

@@ -61,8 +61,6 @@ class LiveEdit : AllStatic {

enum FrameDropMode {

// No frame has been dropped.

FRAMES_UNTOUCHED,

- // The top JS frame had been calling IC stub. IC stub mustn't be called now.

- FRAME_DROPPED_IN_IC_CALL,

// The top JS frame had been calling debug break slot stub. Patch the

// address this stub jumps to in the end.

FRAME_DROPPED_IN_DEBUG_SLOT_CALL,

« no previous file with comments | « src/debug/ia32/debug-ia32.cc ('k') | src/debug/liveedit.cc » ('j') | no next file with comments »