Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1157)

Issue 1491683003: Account for embedded constant pool pointer in Live Edit frame. (Closed)

Created:
5 years ago by MTBrandyberry
Modified:
5 years ago
Reviewers:
mvstanton, Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Account for embedded constant pool pointer in Live Edit frame. R=mvstanton@chromium.org, yangguo@chromium.org BUG= Committed: https://crrev.com/d0b30d02762353c2b5de8a46f99694ea87d38691 Cr-Commit-Position: refs/heads/master@{#32518}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/debug/liveedit.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
MTBrandyberry
5 years ago (2015-12-01 22:11:38 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1491683003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1491683003/1
5 years ago (2015-12-01 22:19:54 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-01 23:19:19 UTC) #5
Yang
On 2015/12/01 23:19:19, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
5 years ago (2015-12-02 08:14:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1491683003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1491683003/1
5 years ago (2015-12-02 14:29:14 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-02 14:30:12 UTC) #9
commit-bot: I haz the power
5 years ago (2015-12-02 14:30:56 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d0b30d02762353c2b5de8a46f99694ea87d38691
Cr-Commit-Position: refs/heads/master@{#32518}

Powered by Google App Engine
This is Rietveld 408576698