Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/debug/liveedit.h

Issue 1491683003: Account for embedded constant pool pointer in Live Edit frame. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_DEBUG_LIVEEDIT_H_ 5 #ifndef V8_DEBUG_LIVEEDIT_H_
6 #define V8_DEBUG_LIVEEDIT_H_ 6 #define V8_DEBUG_LIVEEDIT_H_
7 7
8 8
9 // Live Edit feature implementation. 9 // Live Edit feature implementation.
10 // User should be able to change script on already running VM. This feature 10 // User should be able to change script on already running VM. This feature
(...skipping 154 matching lines...) Expand 10 before | Expand all | Expand 10 after
165 * - 3 context/type words of a regular InternalFrame 165 * - 3 context/type words of a regular InternalFrame
166 * - fp 166 * - fp
167 * --- 167 * ---
168 * Topmost JavaScript frame 168 * Topmost JavaScript frame
169 * --- 169 * ---
170 * ... 170 * ...
171 * --- Bottom 171 * --- Bottom
172 */ 172 */
173 // A size of frame base including fp. Padding words starts right above 173 // A size of frame base including fp. Padding words starts right above
174 // the base. 174 // the base.
175 static const int kFrameDropperFrameSize = 4; 175 static const int kFrameDropperFrameSize =
176 4 + StandardFrameConstants::kCPSlotCount;
176 // A number of words that should be reserved on stack for the LiveEdit use. 177 // A number of words that should be reserved on stack for the LiveEdit use.
177 // Stored on stack in form of Smi. 178 // Stored on stack in form of Smi.
178 static const int kFramePaddingInitialSize = 1; 179 static const int kFramePaddingInitialSize = 1;
179 // A value that padding words are filled with (in form of Smi). Going 180 // A value that padding words are filled with (in form of Smi). Going
180 // bottom-top, the first word not having this value is a counter word. 181 // bottom-top, the first word not having this value is a counter word.
181 static const int kFramePaddingValue = kFramePaddingInitialSize + 1; 182 static const int kFramePaddingValue = kFramePaddingInitialSize + 1;
182 }; 183 };
183 184
184 185
185 // A general-purpose comparator between 2 arrays. 186 // A general-purpose comparator between 2 arrays.
(...skipping 175 matching lines...) Expand 10 before | Expand all | Expand 10 after
361 static const int kSharedInfoOffset_ = 3; 362 static const int kSharedInfoOffset_ = 3;
362 static const int kSize_ = 4; 363 static const int kSize_ = 4;
363 364
364 friend class JSArrayBasedStruct<SharedInfoWrapper>; 365 friend class JSArrayBasedStruct<SharedInfoWrapper>;
365 }; 366 };
366 367
367 } // namespace internal 368 } // namespace internal
368 } // namespace v8 369 } // namespace v8
369 370
370 #endif /* V8_DEBUG_LIVEEDIT_H_ */ 371 #endif /* V8_DEBUG_LIVEEDIT_H_ */
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698