Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(536)

Issue 1491603002: Add android_stats.py script (Closed)

Created:
5 years ago by borenet
Modified:
5 years ago
Reviewers:
rmistry, djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/buildbot@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add android_stats.py script Dumps out information about all connected devices: - Battery - Temperature - Model name ...in JSON format. BUG=skia:4606 Committed: https://skia.googlesource.com/buildbot/+/ca966f9ca59b8dc9e880b129aa3768eb69965f8c

Patch Set 1 #

Patch Set 2 : Fix comment #

Total comments: 9
Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -0 lines) Patch
A scripts/android_stats.py View 1 1 chunk +86 lines, -0 lines 9 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (4 generated)
borenet
5 years ago (2015-12-01 16:19:26 UTC) #2
rmistry
https://codereview.chromium.org/1491603002/diff/20001/scripts/android_stats.py File scripts/android_stats.py (right): https://codereview.chromium.org/1491603002/diff/20001/scripts/android_stats.py#newcode43 scripts/android_stats.py:43: cmd = ['adb', '-s', serial, 'shell', 'dumpsys', 'batteryproperties'] I ...
5 years ago (2015-12-01 16:33:17 UTC) #3
borenet
+djsollen for advice on better ways to get this information. https://codereview.chromium.org/1491603002/diff/20001/scripts/android_stats.py File scripts/android_stats.py (right): https://codereview.chromium.org/1491603002/diff/20001/scripts/android_stats.py#newcode43 ...
5 years ago (2015-12-01 20:00:07 UTC) #5
djsollen
lgtm https://codereview.chromium.org/1491603002/diff/20001/scripts/android_stats.py File scripts/android_stats.py (right): https://codereview.chromium.org/1491603002/diff/20001/scripts/android_stats.py#newcode43 scripts/android_stats.py:43: cmd = ['adb', '-s', serial, 'shell', 'dumpsys', 'batteryproperties'] ...
5 years ago (2015-12-02 15:46:04 UTC) #6
borenet
https://codereview.chromium.org/1491603002/diff/20001/scripts/android_stats.py File scripts/android_stats.py (right): https://codereview.chromium.org/1491603002/diff/20001/scripts/android_stats.py#newcode54 scripts/android_stats.py:54: temp_file = '/sys/devices/virtual/thermal/thermal_zone0/temp' On 2015/12/02 15:46:03, djsollen wrote: > ...
5 years ago (2015-12-02 15:59:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1491603002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1491603002/20001
5 years ago (2015-12-02 15:59:34 UTC) #9
commit-bot: I haz the power
5 years ago (2015-12-02 16:03:50 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/buildbot/+/ca966f9ca59b8dc9e880b129aa3768eb6996...

Powered by Google App Engine
This is Rietveld 408576698