Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1491583002:
Fixing gcc warning 'variable tracking size limit exceeded' (Closed)
|
Created:
5 years ago by ivica.bogosavljevic Modified:
5 years ago CC:
v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
DescriptionFixing gcc warning 'variable tracking size limit exceeded'
Warning in test-asm-validator.cc fixed by splitting the function causing the warning into two functions. This
is how it has been done earlier this way, e.g. https://codereview.chromium.org/1164893003
BUG=
Committed: https://crrev.com/e667ae4ba98cbe29c4ed40ade2681e0af310eb3a
Cr-Commit-Position: refs/heads/master@{#32575}
Patch Set 1 #
Messages
Total messages: 23 (11 generated)
Description was changed from ========== test-asm-validator.cc: Fixing gcc warning 'variable tracking size limit exceeded' Warning fixed by splitting the function causing the warning into two functions. This is how it has been done eariler this way, e.g. https://codereview.chromium.org/1164893003 BUG= ========== to ========== test-asm-validator.cc: Fixing gcc warning 'variable tracking size limit exceeded' Warning fixed by splitting the function causing the warning into two functions. This is how it has been done eariler this way, e.g. https://codereview.chromium.org/1164893003 BUG= ==========
ivica.bogosavljevic@imgtec.com changed reviewers: + paul.lind@imgtec.com
The CQ bit was checked by ivica.bogosavljevic@imgtec.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1491583002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1491583002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
LGTM (to hopefully allow you to run trybots. I am not owner for this file, so we will need v8 team approval before landing.)
Also, nit on commit message, please 'Edit' title to: Fix gcc warning 'variable tracking size limit exceeded'. It is not common to put filenames in the title.
Description was changed from ========== test-asm-validator.cc: Fixing gcc warning 'variable tracking size limit exceeded' Warning fixed by splitting the function causing the warning into two functions. This is how it has been done eariler this way, e.g. https://codereview.chromium.org/1164893003 BUG= ========== to ========== Fixing gcc warning 'variable tracking size limit exceeded' Warning in test-asm-validator.cc fixed by splitting the function causing the warning into two functions. This is how it has been done earlier this way, e.g. https://codereview.chromium.org/1164893003 BUG= ==========
The CQ bit was checked by ivica.bogosavljevic@imgtec.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1491583002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1491583002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
paul.lind@imgtec.com changed reviewers: + jkummerow@chromium.org, titzer@chromium.org
LGTM, but this needs v8 team review, could one of you guys PTAL?
On 2015/12/03 14:51:05, paul.l... wrote: > LGTM, but this needs v8 team review, could one of you guys PTAL? lgtm
The CQ bit was checked by ivica.bogosavljevic@imgtec.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1491583002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1491583002/1
Message was sent while issue was closed.
Description was changed from ========== Fixing gcc warning 'variable tracking size limit exceeded' Warning in test-asm-validator.cc fixed by splitting the function causing the warning into two functions. This is how it has been done earlier this way, e.g. https://codereview.chromium.org/1164893003 BUG= ========== to ========== Fixing gcc warning 'variable tracking size limit exceeded' Warning in test-asm-validator.cc fixed by splitting the function causing the warning into two functions. This is how it has been done earlier this way, e.g. https://codereview.chromium.org/1164893003 BUG= ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Fixing gcc warning 'variable tracking size limit exceeded' Warning in test-asm-validator.cc fixed by splitting the function causing the warning into two functions. This is how it has been done earlier this way, e.g. https://codereview.chromium.org/1164893003 BUG= ========== to ========== Fixing gcc warning 'variable tracking size limit exceeded' Warning in test-asm-validator.cc fixed by splitting the function causing the warning into two functions. This is how it has been done earlier this way, e.g. https://codereview.chromium.org/1164893003 BUG= Committed: https://crrev.com/e667ae4ba98cbe29c4ed40ade2681e0af310eb3a Cr-Commit-Position: refs/heads/master@{#32575} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/e667ae4ba98cbe29c4ed40ade2681e0af310eb3a Cr-Commit-Position: refs/heads/master@{#32575} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
