Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1164893003: Files.app: Fix gcc warning 'variable tracking size limit exceeded'. (Closed)

Created:
5 years, 6 months ago by fukino
Modified:
5 years, 6 months ago
Reviewers:
mtomasz
CC:
chromium-reviews, extensions-reviews_chromium.org, rginda+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Files.app: Fix gcc warning 'variable tracking size limit exceeded'. Fixed the warning by reducing the number of assignments in FileManagerPrivateGetStringsFunction::RunSync(). BUG=491743 TEST=build chrome for chromeos using gcc Committed: https://crrev.com/10f1c328ce0d9de845a552b8e40fa811a77f7695 Cr-Commit-Position: refs/heads/master@{#332593}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -75 lines) Patch
M chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc View 6 chunks +85 lines, -75 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
fukino
Tomasz, could you take a look? Thanks!
5 years, 6 months ago (2015-06-03 08:39:53 UTC) #2
mtomasz
lgtm, thanks!
5 years, 6 months ago (2015-06-03 10:33:03 UTC) #3
fukino
On 2015/06/03 10:33:03, mtomasz wrote: > lgtm, thanks! Thank you!
5 years, 6 months ago (2015-06-03 11:09:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1164893003/1
5 years, 6 months ago (2015-06-03 11:10:12 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-03 11:43:26 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-03 11:44:28 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/10f1c328ce0d9de845a552b8e40fa811a77f7695
Cr-Commit-Position: refs/heads/master@{#332593}

Powered by Google App Engine
This is Rietveld 408576698