Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 1491563003: Fix Android framework build (Closed)

Created:
5 years ago by scroggo
Modified:
5 years ago
Reviewers:
bsalomon, tomhudson
CC:
reviews_skia.org, Kimmo Kinnunen
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix Android framework build eeebdb538d476c1bfc8b63a946094ca1b505ecd1 did not update a Config that only builds if SK_BUILD_FOR_ANDROID_FRAMEWORK. This appears to be the necessary parameter that is missing. BUG=skia:2992 Committed: https://skia.googlesource.com/skia/+/cb6cb21cd9d27054810d2c80ef534dcddd615d4b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M bench/nanobench.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
scroggo
5 years ago (2015-12-01 15:38:41 UTC) #2
bsalomon
lgtm
5 years ago (2015-12-01 15:39:19 UTC) #3
tomhudson
lgtm
5 years ago (2015-12-01 15:41:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1491563003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1491563003/1
5 years ago (2015-12-01 15:41:19 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/cb6cb21cd9d27054810d2c80ef534dcddd615d4b
5 years ago (2015-12-01 15:53:40 UTC) #8
scroggo
5 years ago (2015-12-01 16:08:09 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1487033002/ by scroggo@google.com.

The reason for reverting is: eeebdb538d476c1bfc8b63a946094ca1b505ecd1 was
reverted, so this one needs to be reverted, too.

Powered by Google App Engine
This is Rietveld 408576698