Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 1491433002: PPC: [runtime] Replace global object link with native context link in all contexts. (Closed)

Created:
5 years ago by MTBrandyberry
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@patch11
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [runtime] Replace global object link with native context link in all contexts. Port 47502a238b8185a864bfe6a8d5508b4e67cad40e Original commit message: Previously all contexts had a link to the global object, but what is required in most cases (except for the global load, store and delete case) is the native context. This also removes the second dummy global object that was still linked to every native context. We will add a different mechanism to ensure that builtins do not pollute the actual global object during bootstrapping. Drive-by-fix: Unify some MacroAssembler magic and drop obsolete stuff. R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/aeab4a96501ec6c74724b2df3fff134fc4ca5cbc Cr-Commit-Position: refs/heads/master@{#32435}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -143 lines) Patch
M src/crankshaft/ppc/lithium-codegen-ppc.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 15 chunks +22 lines, -29 lines 0 comments Download
M src/ic/ppc/handler-compiler-ppc.cc View 1 chunk +1 line, -5 lines 0 comments Download
M src/ppc/builtins-ppc.cc View 3 chunks +6 lines, -22 lines 0 comments Download
M src/ppc/code-stubs-ppc.cc View 8 chunks +13 lines, -21 lines 0 comments Download
M src/ppc/macro-assembler-ppc.h View 4 chunks +12 lines, -12 lines 0 comments Download
M src/ppc/macro-assembler-ppc.cc View 5 chunks +7 lines, -49 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 8 (2 generated)
MTBrandyberry
5 years ago (2015-11-30 21:02:46 UTC) #1
michael_dawson
On 2015/11/30 21:02:46, mtbrandyberry wrote: lgtm
5 years ago (2015-11-30 21:33:02 UTC) #2
john.yan
lgtm
5 years ago (2015-11-30 22:53:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1491433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1491433002/1
5 years ago (2015-12-01 03:36:11 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-01 03:53:32 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-01 03:53:55 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aeab4a96501ec6c74724b2df3fff134fc4ca5cbc
Cr-Commit-Position: refs/heads/master@{#32435}

Powered by Google App Engine
This is Rietveld 408576698