Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1487873002: PPC: Refine "Deprecate unused RelocInfo::CONSTRUCT_CALL mode." (Closed)

Created:
5 years ago by MTBrandyberry
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@patch12
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: Refine "Deprecate unused RelocInfo::CONSTRUCT_CALL mode." R=mstarzinger@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/f2a5cd43458b1958ce1a89a0a6db37e29b9d29b2 Cr-Commit-Position: refs/heads/master@{#32436}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M src/ppc/macro-assembler-ppc.cc View 1 chunk +1 line, -2 lines 0 comments Download

Depends on Patchset:

Issue 1491433002 Patch 1

Dependent Patchsets:

Issue 1491453002 Patch 1

Messages

Total messages: 9 (2 generated)
MTBrandyberry
5 years ago (2015-11-30 21:05:59 UTC) #1
michael_dawson
On 2015/11/30 21:05:59, mtbrandyberry wrote: lgtm
5 years ago (2015-11-30 21:33:33 UTC) #2
Michael Starzinger
LGTM. Ooops, totally missed that. Thanks!
5 years ago (2015-11-30 22:07:27 UTC) #3
john.yan
lgtm
5 years ago (2015-11-30 22:51:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1487873002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1487873002/1
5 years ago (2015-12-01 03:55:44 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-01 04:11:39 UTC) #7
commit-bot: I haz the power
5 years ago (2015-12-01 04:12:16 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/f2a5cd43458b1958ce1a89a0a6db37e29b9d29b2
Cr-Commit-Position: refs/heads/master@{#32436}

Powered by Google App Engine
This is Rietveld 408576698