Disallow non-hyphenated-identifier tag names.

lib/src/runner/parse_metadata.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test.runner.parse_metadata;
 
 import 'dart:io';
 
 import 'package:analyzer/analyzer.dart';
 import 'package:analyzer/src/generated/ast.dart';
@@ skipping 158 matching lines @@
   }
 
   /// Parses a `@Tags` annotation.
   ///
   /// [annotation] is the annotation. [constructorName] is the name of the named
   /// constructor for the annotation, if any.
   Set<String> _parseTags(Annotation annotation, String constructorName) {
     _assertConstructorName(constructorName, 'Tags', annotation);
     _assertArguments(annotation.arguments, 'Tags', annotation, positional: 1);
 
-    return _parseList(annotation.arguments.arguments.first)
-        .map((tagExpression) => _parseString(tagExpression).stringValue)
-        .toSet();
+    return _parseList(annotation.arguments.arguments.first).map((tagExpression) {
+      var name = _parseString(tagExpression).stringValue;
+      if (name.contains(anchoredHyphenatedIdentifier)) return name;
+
+      throw new SourceSpanFormatException(
+          "Invalid tag name. Tags must be (optionally hyphenated) Dart "
+            "identifiers.",
+          _spanFor(tagExpression));
+    }).toSet();
   }
 
   /// Parses an `@OnPlatform` annotation.
   ///
   /// [annotation] is the annotation. [constructorName] is the name of the named
   /// constructor for the annotation, if any.
   Map<PlatformSelector, Metadata> _parseOnPlatform(Annotation annotation,
       String constructorName) {
     _assertConstructorName(constructorName, 'OnPlatform', annotation);
     _assertArguments(annotation.arguments, 'OnPlatform', annotation,
@@ skipping 337 matching lines @@
       return fn();
     } on SourceSpanFormatException catch (error) {
       var file = new SourceFile(new File(_path).readAsStringSync(),
           url: p.toUri(_path));
       var span = contextualizeSpan(error.span, literal, file);
       if (span == null) rethrow;
       throw new SourceSpanFormatException(error.message, span);
     }
   }
 }