Issue 1491373006: When an offline page is saved to homescreen, use the online URL.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1491373006: When an offline page is saved to homescreen, use the online URL. (Closed)

Created:
5 years ago by dewittj

Modified:
5 years ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2564

Target Ref:
refs/pending/branch-heads/2564

Project:
chromium

Visibility:
Public.

When an offline page is saved to homescreen, use the online URL. BUG=560752 Review URL: https://codereview.chromium.org/1489873004 Cr-Commit-Position: refs/heads/master@{#362857} (cherry picked from commit 77c735a0eb3207605a8b5f841574468d7dcb8c81) Committed: https://chromium.googlesource.com/chromium/src/+/d0020017dc4798c187444749b2c05febcda31f24

Created: 5 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -2 lines)			Patch
	M	chrome/browser/android/webapps/add_to_homescreen_data_fetcher.h	View		1 chunk	+5 lines, -0 lines	0 comments	Download
	M	chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc	View		4 chunks	+25 lines, -2 lines	0 comments	Download

Total messages: 2 (1 generated)

dewittj

5 years ago (2015-12-03 21:33:00 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
d0020017dc4798c187444749b2c05febcda31f24.