Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(625)

Issue 1489873004: When an offline page is saved to homescreen, use the online URL. (Closed)

Created:
5 years ago by dewittj
Modified:
5 years ago
Reviewers:
Ted C, gone, fgorski
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

When an offline page is saved to homescreen, use the online URL. BUG=560752 Committed: https://crrev.com/77c735a0eb3207605a8b5f841574468d7dcb8c81 Cr-Commit-Position: refs/heads/master@{#362857}

Patch Set 1 #

Patch Set 2 : Adds docs for the new convenience method. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -2 lines) Patch
M chrome/browser/android/webapps/add_to_homescreen_data_fetcher.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc View 4 chunks +25 lines, -2 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
fgorski
lgtm
5 years ago (2015-12-01 22:39:04 UTC) #3
dewittj
dfalcantara, ptal I'm in the process of trying to write a unit test, the first ...
5 years ago (2015-12-02 00:59:29 UTC) #4
dewittj
tedchoc, ptal as dfalcantara appears away. Looks like a unit test will be fairly involved ...
5 years ago (2015-12-02 18:26:12 UTC) #8
Ted C
lgtm
5 years ago (2015-12-03 00:22:32 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1489873004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1489873004/20001
5 years ago (2015-12-03 00:24:17 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/74552)
5 years ago (2015-12-03 00:41:09 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1489873004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1489873004/20001
5 years ago (2015-12-03 01:09:20 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-03 01:53:34 UTC) #17
commit-bot: I haz the power
5 years ago (2015-12-03 01:54:52 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/77c735a0eb3207605a8b5f841574468d7dcb8c81
Cr-Commit-Position: refs/heads/master@{#362857}

Powered by Google App Engine
This is Rietveld 408576698