Add chrome crash service to GN build on Windows.

Add chrome crash service to GN build on Windows.

This adds a chrome crash_service target that matches the target arch, and a *_win64 version when compiling 32-bit targets.

Previosly we had a crash_service.exe target that was actually the content_shell one with the wrong name. Various code referred to this target when some meant the chrome one, and some meant the content one. This patch fixes the naming and updates the references to use the correct one.

Fixes cross-compiling of generated buildflag headers. It was computing the output directory incorrectly.

BUG=537009
Committed: https://crrev.com/0d3b1dfc7ad173af97ca0f897319ab137d4cf634
Cr-Commit-Position: refs/heads/master@{#362826}

[brettw, 2015-12-02 21:41:52]

brettw@chromium.org changed reviewers:
+ scottmg@chromium.org

[brettw, 2015-12-02 21:41:55]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-02 21:43:42]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1491363002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1491363002/1

[scottmg, 2015-12-02 21:46:32]

lgtm

https://codereview.chromium.org/1491363002/diff/1/components/crash/content/to...
File components/crash/content/tools/BUILD.gn (right):

https://codereview.chromium.org/1491363002/diff/1/components/crash/content/to...
components/crash/content/tools/BUILD.gn:5: source_set("crash_service") {
Maybe an assert(is_win) here too? Or is it used elsewhere? The //BUILD.gn dep is
only Windows though.

[brettw, 2015-12-02 22:16:57]

add is_win

[brettw, 2015-12-02 22:16:58]

The CQ bit was checked by brettw@chromium.org

[brettw, 2015-12-02 22:16:58]

The patchset sent to the CQ was uploaded after l-g-t-m from scottmg@chromium.org
Link to the patchset: https://codereview.chromium.org/1491363002/#ps20001
(title: "add is_win")

[commit-bot: I haz the power, 2015-12-02 22:17:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1491363002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1491363002/20001

[commit-bot: I haz the power, 2015-12-02 22:24:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-02 22:24:32]

Try jobs failed on following builders:
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)

[brettw, 2015-12-02 22:25:12]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2015-12-02 22:26:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1491363002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1491363002/20001

[commit-bot: I haz the power, 2015-12-03 00:10:11]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-03 00:10:53]

Description was changed from

==========
Add chrome crash service to GN build on Windows.

This adds a chrome crash_service target that matches the target arch, and a
*_win64 version when compiling 32-bit targets.

Previosly we had a crash_service.exe target that was actually the content_shell
one with the wrong name. Various code referred to this target when some meant
the chrome one, and some meant the content one. This patch fixes the naming and
updates the references to use the correct one.

Fixes cross-compiling of generated buildflag headers. It was computing the
output directory incorrectly.

BUG=537009
==========

to

==========
Add chrome crash service to GN build on Windows.

This adds a chrome crash_service target that matches the target arch, and a
*_win64 version when compiling 32-bit targets.

Previosly we had a crash_service.exe target that was actually the content_shell
one with the wrong name. Various code referred to this target when some meant
the chrome one, and some meant the content one. This patch fixes the naming and
updates the references to use the correct one.

Fixes cross-compiling of generated buildflag headers. It was computing the
output directory incorrectly.

BUG=537009

Committed: https://crrev.com/0d3b1dfc7ad173af97ca0f897319ab137d4cf634
Cr-Commit-Position: refs/heads/master@{#362826}
==========

[commit-bot: I haz the power, 2015-12-03 00:10:54]

Patchset 2 (id:??) landed as
https://crrev.com/0d3b1dfc7ad173af97ca0f897319ab137d4cf634
Cr-Commit-Position: refs/heads/master@{#362826}