Issue 1491273003: Revert of Add all components to "gn check".

Issue 1491273003: Revert of Add all components to "gn check". (Closed)

Created:
5 years ago by gab

Modified:
5 years ago

Reviewers:
Dirk Pranke, brettw

CC:
chromium-reviews, tim+watch_chromium.org, ozone-reviews_chromium.org, zea+watch_chromium.org, maxbogue+watch_chromium.org, pvalenzuela+watch_chromium.org, plaree+watch_chromium.org, kalyank

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Revert of Add all components to "gn check". (patchset #2 id:20001 of https://codereview.chromium.org/1490113006/ ) Reason for revert: Breaks Linux ChromeOS GN: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20GN%20(dbg) Log: /b/build/slave/Linux_ChromiumOS_GN__dbg_/build/src/buildtools/linux64/gn gen //out/Debug '--args=target_os="chromeos" is_debug=true is_component_build=true use_goma=true goma_dir="/b/build/goma"' --check --runtime-deps-list-file=/b/build/slave/Linux_ChromiumOS_GN__dbg_/build/src/out/Debug/runtime_deps -> returned 1 ERROR Unresolved dependencies. //ui/ozone:ozone(//build/toolchain/linux:clang_x64) needs //ui/events/ozone:events_ozone(//build/toolchain/linux:clang_x64) //ui/ozone/platform/drm:gbm(//build/toolchain/linux:clang_x64) needs //ui/events/ozone:events_ozone_evdev(//build/toolchain/linux:clang_x64) //ui/ozone/platform/egltest:egltest(//build/toolchain/linux:clang_x64) needs //ui/events/ozone:events_ozone_evdev(//build/toolchain/linux:clang_x64) Original issue's description: > Add all components to "gn check". > > All components now pass a "gn check" step. Whitelist with a wildcard. > > R=dpranke@chromium.org > Reland of https://codereview.chromium.org/1491743002 > > Committed: https://crrev.com/3b5cac24943ce9e682c806f844a6aec90481774c > Cr-Commit-Position: refs/heads/master@{#362776} TBR=dpranke@chromium.org,brettw@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/2794da916ecdaac9be51f77b2206d4b88b9e1e45 Cr-Commit-Position: refs/heads/master@{#362785}

Patch Set 1 #

Created: 5 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+161 lines, -28 lines)			Patch
M	.gn	View	1 chunk	+152 lines, -1 line	0 comments	Download
M	components/arc/BUILD.gn	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	components/exo/BUILD.gn	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	components/exo/wayland/BUILD.gn	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	components/version_info/version_info.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	components/wifi_sync/BUILD.gn	View	2 chunks	+7 lines, -18 lines	0 comments	Download
M	ui/ozone/BUILD.gn	View	1 chunk	+1 line, -4 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1491273003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1491273003/1

5 years ago (2015-12-02 20:34:48 UTC) #2

commit-bot: I haz the power

Description was changed from ========== Revert of Add all components to "gn check". (patchset #2 ...

5 years ago (2015-12-02 20:37:56 UTC) #3

Message was sent while issue was closed.

Description was changed from

==========
Revert of Add all components to "gn check". (patchset #2 id:20001 of
https://codereview.chromium.org/1490113006/ )

Reason for revert:
Breaks Linux ChromeOS GN:
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%2...

Log: 
/b/build/slave/Linux_ChromiumOS_GN__dbg_/build/src/buildtools/linux64/gn gen
//out/Debug '--args=target_os="chromeos" is_debug=true is_component_build=true
use_goma=true goma_dir="/b/build/goma"' --check
--runtime-deps-list-file=/b/build/slave/Linux_ChromiumOS_GN__dbg_/build/src/out/Debug/runtime_deps
  -> returned 1
ERROR Unresolved dependencies.
//ui/ozone:ozone(//build/toolchain/linux:clang_x64)
  needs //ui/events/ozone:events_ozone(//build/toolchain/linux:clang_x64)
//ui/ozone/platform/drm:gbm(//build/toolchain/linux:clang_x64)
  needs //ui/events/ozone:events_ozone_evdev(//build/toolchain/linux:clang_x64)
//ui/ozone/platform/egltest:egltest(//build/toolchain/linux:clang_x64)
  needs //ui/events/ozone:events_ozone_evdev(//build/toolchain/linux:clang_x64)

Original issue's description:
> Add all components to "gn check".
> 
> All components now pass a "gn check" step. Whitelist with a wildcard.
> 
> R=dpranke@chromium.org
> Reland of https://codereview.chromium.org/1491743002
> 
> Committed: https://crrev.com/3b5cac24943ce9e682c806f844a6aec90481774c
> Cr-Commit-Position: refs/heads/master@{#362776}

TBR=dpranke@chromium.org,brettw@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
==========

to

==========
Revert of Add all components to "gn check". (patchset #2 id:20001 of
https://codereview.chromium.org/1490113006/ )

Reason for revert:
Breaks Linux ChromeOS GN:
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%2...

Log: 
/b/build/slave/Linux_ChromiumOS_GN__dbg_/build/src/buildtools/linux64/gn gen
//out/Debug '--args=target_os="chromeos" is_debug=true is_component_build=true
use_goma=true goma_dir="/b/build/goma"' --check
--runtime-deps-list-file=/b/build/slave/Linux_ChromiumOS_GN__dbg_/build/src/out/Debug/runtime_deps
  -> returned 1
ERROR Unresolved dependencies.
//ui/ozone:ozone(//build/toolchain/linux:clang_x64)
  needs //ui/events/ozone:events_ozone(//build/toolchain/linux:clang_x64)
//ui/ozone/platform/drm:gbm(//build/toolchain/linux:clang_x64)
  needs //ui/events/ozone:events_ozone_evdev(//build/toolchain/linux:clang_x64)
//ui/ozone/platform/egltest:egltest(//build/toolchain/linux:clang_x64)
  needs //ui/events/ozone:events_ozone_evdev(//build/toolchain/linux:clang_x64)

Original issue's description:
> Add all components to "gn check".
> 
> All components now pass a "gn check" step. Whitelist with a wildcard.
> 
> R=dpranke@chromium.org
> Reland of https://codereview.chromium.org/1491743002
> 
> Committed: https://crrev.com/3b5cac24943ce9e682c806f844a6aec90481774c
> Cr-Commit-Position: refs/heads/master@{#362776}

TBR=dpranke@chromium.org,brettw@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
==========

commit-bot: I haz the power

Description was changed from ========== Revert of Add all components to "gn check". (patchset #2 ...

5 years ago (2015-12-02 20:39:34 UTC) #5

Message was sent while issue was closed.

Description was changed from

==========
Revert of Add all components to "gn check". (patchset #2 id:20001 of
https://codereview.chromium.org/1490113006/ )

Reason for revert:
Breaks Linux ChromeOS GN:
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%2...

Log: 
/b/build/slave/Linux_ChromiumOS_GN__dbg_/build/src/buildtools/linux64/gn gen
//out/Debug '--args=target_os="chromeos" is_debug=true is_component_build=true
use_goma=true goma_dir="/b/build/goma"' --check
--runtime-deps-list-file=/b/build/slave/Linux_ChromiumOS_GN__dbg_/build/src/out/Debug/runtime_deps
  -> returned 1
ERROR Unresolved dependencies.
//ui/ozone:ozone(//build/toolchain/linux:clang_x64)
  needs //ui/events/ozone:events_ozone(//build/toolchain/linux:clang_x64)
//ui/ozone/platform/drm:gbm(//build/toolchain/linux:clang_x64)
  needs //ui/events/ozone:events_ozone_evdev(//build/toolchain/linux:clang_x64)
//ui/ozone/platform/egltest:egltest(//build/toolchain/linux:clang_x64)
  needs //ui/events/ozone:events_ozone_evdev(//build/toolchain/linux:clang_x64)

Original issue's description:
> Add all components to "gn check".
> 
> All components now pass a "gn check" step. Whitelist with a wildcard.
> 
> R=dpranke@chromium.org
> Reland of https://codereview.chromium.org/1491743002
> 
> Committed: https://crrev.com/3b5cac24943ce9e682c806f844a6aec90481774c
> Cr-Commit-Position: refs/heads/master@{#362776}

TBR=dpranke@chromium.org,brettw@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
==========

to

==========
Revert of Add all components to "gn check". (patchset #2 id:20001 of
https://codereview.chromium.org/1490113006/ )

Reason for revert:
Breaks Linux ChromeOS GN:
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%2...

Log:
/b/build/slave/Linux_ChromiumOS_GN__dbg_/build/src/buildtools/linux64/gn gen
//out/Debug '--args=target_os="chromeos" is_debug=true is_component_build=true
use_goma=true goma_dir="/b/build/goma"' --check
--runtime-deps-list-file=/b/build/slave/Linux_ChromiumOS_GN__dbg_/build/src/out/Debug/runtime_deps
  -> returned 1
ERROR Unresolved dependencies.
//ui/ozone:ozone(//build/toolchain/linux:clang_x64)
  needs //ui/events/ozone:events_ozone(//build/toolchain/linux:clang_x64)
//ui/ozone/platform/drm:gbm(//build/toolchain/linux:clang_x64)
  needs //ui/events/ozone:events_ozone_evdev(//build/toolchain/linux:clang_x64)
//ui/ozone/platform/egltest:egltest(//build/toolchain/linux:clang_x64)
  needs //ui/events/ozone:events_ozone_evdev(//build/toolchain/linux:clang_x64)

Original issue's description:
> Add all components to "gn check".
>
> All components now pass a "gn check" step. Whitelist with a wildcard.
>
> R=dpranke@chromium.org
> Reland of https://codereview.chromium.org/1491743002
>
> Committed: https://crrev.com/3b5cac24943ce9e682c806f844a6aec90481774c
> Cr-Commit-Position: refs/heads/master@{#362776}

TBR=dpranke@chromium.org,brettw@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Committed: https://crrev.com/2794da916ecdaac9be51f77b2206d4b88b9e1e45
Cr-Commit-Position: refs/heads/master@{#362785}
==========

commit-bot: I haz the power

5 years ago (2015-12-02 20:39:35 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/2794da916ecdaac9be51f77b2206d4b88b9e1e45
Cr-Commit-Position: refs/heads/master@{#362785}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages