Add all components to "gn check".

Add all components to "gn check".

All components now pass a "gn check" step. Whitelist with a wildcard.

R=dpranke@chromium.org

Committed: https://crrev.com/273b751649ebe3cc3579d9c87166ed3802827fb0
Cr-Commit-Position: refs/heads/master@{#362652}

[brettw, 2015-12-02 00:07:05]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-02 00:08:53]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1491743002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1491743002/1

[commit-bot: I haz the power, 2015-12-02 01:59:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-02 01:59:23]

Dry run: Try jobs failed on following builders:
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Dirk Pranke, 2015-12-02 02:27:44]

<burns-voice>excellent</burns-voice>

lgtm.

[brettw, 2015-12-02 05:42:12]

chromeos

[brettw, 2015-12-02 05:46:47]

I had to add some chromeos stuff.

[brettw, 2015-12-02 05:46:54]

Description was changed from

==========
Add all components to "gn check".

All components now pass a "gn check" step. Whitelist with a wildcard.

TBR=dpranke@chromium.org
==========

to

==========
Add all components to "gn check".

All components now pass a "gn check" step. Whitelist with a wildcard.

R=dpranke@chromium.org
==========

[brettw, 2015-12-02 05:47:00]

The CQ bit was checked by brettw@chromium.org

[brettw, 2015-12-02 05:47:00]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/1491743002/#ps20001
(title: "chromeos")

[commit-bot: I haz the power, 2015-12-02 05:47:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1491743002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1491743002/20001

[commit-bot: I haz the power, 2015-12-02 05:52:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-02 05:52:39]

Try jobs failed on following builders:
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[brettw, 2015-12-02 06:24:31]

more chromeos

[brettw, 2015-12-02 06:24:32]

The CQ bit was checked by brettw@chromium.org

[brettw, 2015-12-02 06:24:32]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/1491743002/#ps40001
(title: "more chromeos")

[commit-bot: I haz the power, 2015-12-02 06:25:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1491743002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1491743002/40001

[commit-bot: I haz the power, 2015-12-02 06:34:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-02 06:34:09]

Try jobs failed on following builders:
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[brettw, 2015-12-02 06:34:11]

more chromeos

[brettw, 2015-12-02 06:34:12]

The CQ bit was checked by brettw@chromium.org

[brettw, 2015-12-02 06:34:12]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/1491743002/#ps60001
(title: "more chromeos")

[commit-bot: I haz the power, 2015-12-02 06:34:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1491743002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1491743002/60001

[commit-bot: I haz the power, 2015-12-02 07:14:51]

Description was changed from

==========
Add all components to "gn check".

All components now pass a "gn check" step. Whitelist with a wildcard.

R=dpranke@chromium.org
==========

to

==========
Add all components to "gn check".

All components now pass a "gn check" step. Whitelist with a wildcard.

R=dpranke@chromium.org
==========

[commit-bot: I haz the power, 2015-12-02 07:14:51]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-12-02 07:16:26]

Description was changed from

==========
Add all components to "gn check".

All components now pass a "gn check" step. Whitelist with a wildcard.

R=dpranke@chromium.org
==========

to

==========
Add all components to "gn check".

All components now pass a "gn check" step. Whitelist with a wildcard.

R=dpranke@chromium.org

Committed: https://crrev.com/273b751649ebe3cc3579d9c87166ed3802827fb0
Cr-Commit-Position: refs/heads/master@{#362652}
==========

[commit-bot: I haz the power, 2015-12-02 07:16:27]

Patchset 4 (id:??) landed as
https://crrev.com/273b751649ebe3cc3579d9c87166ed3802827fb0
Cr-Commit-Position: refs/heads/master@{#362652}

[dtu, 2015-12-02 15:49:58]

Failing on perf Linux Builder:
https://build.chromium.org/p/chromium.perf/builders/Linux%20Builder/builds/7266

Please fix or revert. The perf builders are Official builds, so they may catch
things the main waterfall doesn't.

[dtu, 2015-12-02 16:07:19]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1490313002/ by dtu@chromium.org.

The reason for reverting is: Failing Perf (Official) Linux Builder.
https://build.chromium.org/p/chromium.perf/builders/Linux%20Builder/builds/7266

ERROR at //components/version_info/version_info.cc:12:11: Include not allowed.
#include "ui/base/l10n/l10n_util.h"
          ^-----------------------
It is not in any dependency of
  //components/version_info:version_info
The include file is in the target(s):
  //ui/base:base
which should somehow be reachable.
GN gen failed: 1
.