Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 1491223002: [turbofan] Desugar JSUnaryNot(x) to Select(x, false, true). (Closed)

Created:
5 years ago by Benedikt Meurer
Modified:
5 years ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Desugar JSUnaryNot(x) to Select(x, false, true). Also remove the ResultMode from ToBooleanStub and always return true or false and use the same mechanism in fullcodegen. This is in preparation for adding ToBoolean hints to TurboFan. Drive-by-fix: We can use the power of the ToBooleanIC in TurboFan now that the ResultMode is gone (and the runtime always returns true or false from the miss handler). R=mstarzinger@chromium.org BUG=v8:4583 LOG=n Committed: https://crrev.com/411c5b7fb09f76fca567c3deda3304f77eb3df2f Cr-Commit-Position: refs/heads/master@{#32524}

Patch Set 1 #

Patch Set 2 : Fix typo in arm64. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -239 lines) Patch
M src/code-factory.h View 1 chunk +1 line, -3 lines 0 comments Download
M src/code-factory.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M src/code-stubs.h View 3 chunks +1 line, -17 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 1 chunk +2 lines, -20 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/compiler/bytecode-graph-builder.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 2 chunks +1 line, -11 lines 0 comments Download
M src/compiler/js-operator.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/js-operator.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/js-typed-lowering.h View 3 chunks +3 lines, -1 line 0 comments Download
M src/compiler/js-typed-lowering.cc View 5 chunks +34 lines, -36 lines 0 comments Download
M src/compiler/opcodes.h View 2 chunks +0 lines, -3 lines 0 comments Download
M src/compiler/typer.cc View 2 chunks +0 lines, -11 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M src/ic/ic.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/compiler/js-operator-unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 1 chunk +0 lines, -100 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
5 years ago (2015-12-02 13:40:53 UTC) #1
Benedikt Meurer
Hey Michi, Here's the refactoring for JSUnaryNot we talked about earlier. The idea is that ...
5 years ago (2015-12-02 13:43:36 UTC) #2
Michael Starzinger
LGTM. I like it.
5 years ago (2015-12-02 15:12:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1491223002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1491223002/20001
5 years ago (2015-12-02 15:13:06 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-02 15:21:50 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-02 15:22:22 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/411c5b7fb09f76fca567c3deda3304f77eb3df2f
Cr-Commit-Position: refs/heads/master@{#32524}

Powered by Google App Engine
This is Rietveld 408576698