src/ic/ic.cc - Issue 1491223002: [turbofan] Desugar JSUnaryNot(x) to Select(x, false, true).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ic/ic.cc

Issue 1491223002: [turbofan] Desugar JSUnaryNot(x) to Select(x, false, true). (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix typo in arm64. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ic/ic.cc

diff --git a/src/ic/ic.cc b/src/ic/ic.cc

index 7458551dbfe492da03c00701066bfea30582b701..3a6311b9e2f2d2be078ca9f7632a42a3576c6662 100644

--- a/src/ic/ic.cc

+++ b/src/ic/ic.cc

@@ -2813,7 +2813,7 @@ Handle<Object> ToBooleanIC::ToBoolean(Handle<Object> object) {

bool to_boolean_value = stub.UpdateStatus(object);

Handle<Code> code = stub.GetCode();

set_target(*code);

- return handle(Smi::FromInt(to_boolean_value ? 1 : 0), isolate());

+ return isolate()->factory()->ToBoolean(to_boolean_value);

}

« no previous file with comments | « src/full-codegen/x64/full-codegen-x64.cc ('k') | test/unittests/compiler/js-operator-unittest.cc » ('j') | no next file with comments »