Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 1491213009: Revert of mac: Sign app_mode_loader [badly] (Closed)

Created:
5 years ago by Paweł Hajdan Jr.
Modified:
5 years ago
Reviewers:
Mark Mentovai, Greg K
CC:
chromium-reviews, grt+watch_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of mac: Sign app_mode_loader [badly] (patchset #1 id:1 of https://codereview.chromium.org/1486863003/ ) Reason for revert: Suspected for breaking official signing, see https://code.google.com/p/chromium/issues/detail?id=565859 Original issue's description: > mac: Sign app_mode_loader [badly] > > We can't sign the app_mode_loader bundle because it's altered at runtime > as new app mode loader stubs are created. We can sign just the > executable. The resulting executable won't validate in its bundle > normally, and spctl won't like it, but it can be verified with > --ignore-resources, or in isolation from its bundle. > > BUG=550972 > > Committed: https://crrev.com/2720613d5ea1db967ac883fcc9282ec60ad1ddd5 > Cr-Commit-Position: refs/heads/master@{#363070} TBR=kerrnel@chromium.org,mark@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=550972, 565859 Committed: https://crrev.com/51c465c92024f0905cab2bd16fb56aec404b8d42 Cr-Commit-Position: refs/heads/master@{#363179}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -21 lines) Patch
M chrome/installer/mac/sign_versioned_dir.sh.in View 3 chunks +0 lines, -21 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Paweł Hajdan Jr.
Created Revert of mac: Sign app_mode_loader [badly]
5 years ago (2015-12-04 10:02:25 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1491213009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1491213009/1
5 years ago (2015-12-04 10:03:44 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-04 10:04:35 UTC) #4
commit-bot: I haz the power
5 years ago (2015-12-04 10:05:27 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/51c465c92024f0905cab2bd16fb56aec404b8d42
Cr-Commit-Position: refs/heads/master@{#363179}

Powered by Google App Engine
This is Rietveld 408576698