Set V8 extras mode in gin::V8Initializer.

Set V8 extras mode in gin::V8Initializer.

Currently V8 extras mode is set in content/renderer. In order to enable
the experimental V8 extras in webkit_unit_tests, this change moves the
initialization settings from content/renderrer to gin.

BUG=503491
Committed: https://crrev.com/93150242a4e69124bdd8c45d4444ca9ef7e1767b
Cr-Commit-Position: refs/heads/master@{#363458}

[yhirano, 2015-12-02 04:25:24]

yhirano@chromium.org changed reviewers:
+ domenic@chromium.org, jochen@chromium.org

[jochen (gone - plz use gerrit), 2015-12-02 13:09:18]

https://codereview.chromium.org/1491083002/diff/1/gin/public/isolate_holder.h
File gin/public/isolate_holder.h (right):

https://codereview.chromium.org/1491083002/diff/1/gin/public/isolate_holder.h...
gin/public/isolate_holder.h:59: static void Initialize(ScriptMode mode,
please add the parameter explicitly everywhere

https://codereview.chromium.org/1491083002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in (right):

https://codereview.chromium.org/1491083002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in:75:
ExperimentalV8Extras status=experimental
maybe =test?

[domenic, 2015-12-02 18:07:23]

LGTM with naming change

https://codereview.chromium.org/1491083002/diff/1/gin/public/isolate_holder.h
File gin/public/isolate_holder.h (right):

https://codereview.chromium.org/1491083002/diff/1/gin/public/isolate_holder.h...
gin/public/isolate_holder.h:41: kExperimentalV8Extras,
It'd be less confusing to name this kStableAndExperimentalV8Extras

[haraken, 2015-12-02 23:41:06]

bindings/ LGTM

[yhirano, 2015-12-03 02:21:05]

https://codereview.chromium.org/1491083002/diff/1/gin/public/isolate_holder.h
File gin/public/isolate_holder.h (right):

https://codereview.chromium.org/1491083002/diff/1/gin/public/isolate_holder.h...
gin/public/isolate_holder.h:41: kExperimentalV8Extras,
On 2015/12/02 18:07:23, domenic wrote:
> It'd be less confusing to name this kStableAndExperimentalV8Extras

Done.

https://codereview.chromium.org/1491083002/diff/1/gin/public/isolate_holder.h...
gin/public/isolate_holder.h:59: static void Initialize(ScriptMode mode,
On 2015/12/02 13:09:18, jochen wrote:
> please add the parameter explicitly everywhere

Done.

[yhirano, 2015-12-03 02:22:21]

yhirano@chromium.org changed reviewers:
+ ben@chromium.org

[yhirano, 2015-12-03 02:22:21]

+ben@ for third_party/mojo/edk and net/proxy.

[yhirano, 2015-12-03 04:34:00]

On 2015/12/03 02:22:21, yhirano wrote:
> +ben@ for third_party/mojo/edk and net/proxy.
for
 - mojo/edk
 - third_party/mojo/src/mojo/edk
 - net/proxy

[jochen (gone - plz use gerrit), 2015-12-04 13:15:31]

jochen@chromium.org changed reviewers:
+ haraken@chromium.org

[jochen (gone - plz use gerrit), 2015-12-04 13:15:32]

lgtm

[Ben Goodger (Google), 2015-12-04 18:42:32]

lgtm

[yhirano, 2015-12-07 06:10:08]

The CQ bit was checked by yhirano@chromium.org

[yhirano, 2015-12-07 06:10:08]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, domenic@chromium.org
Link to the patchset: https://codereview.chromium.org/1491083002/#ps40001
(title: " ")

[commit-bot: I haz the power, 2015-12-07 06:10:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1491083002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1491083002/40001

[commit-bot: I haz the power, 2015-12-07 07:37:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-07 07:37:24]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[yhirano, 2015-12-07 08:16:56]

The CQ bit was checked by yhirano@chromium.org

[commit-bot: I haz the power, 2015-12-07 08:18:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1491083002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1491083002/40001

[commit-bot: I haz the power, 2015-12-07 10:01:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-07 10:01:53]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[yhirano, 2015-12-07 11:28:27]

The CQ bit was checked by yhirano@chromium.org

[commit-bot: I haz the power, 2015-12-07 11:29:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1491083002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1491083002/40001

[commit-bot: I haz the power, 2015-12-07 12:28:42]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-12-07 12:29:52]

Description was changed from

==========
Set V8 extras mode in gin::V8Initializer.

Currently V8 extras mode is set in content/renderer. In order to enable
the experimental V8 extras in webkit_unit_tests, this change moves the
initialization settings from content/renderrer to gin.

BUG=503491
==========

to

==========
Set V8 extras mode in gin::V8Initializer.

Currently V8 extras mode is set in content/renderer. In order to enable
the experimental V8 extras in webkit_unit_tests, this change moves the
initialization settings from content/renderrer to gin.

BUG=503491

Committed: https://crrev.com/93150242a4e69124bdd8c45d4444ca9ef7e1767b
Cr-Commit-Position: refs/heads/master@{#363458}
==========

[commit-bot: I haz the power, 2015-12-07 12:29:53]

Patchset 3 (id:??) landed as
https://crrev.com/93150242a4e69124bdd8c45d4444ca9ef7e1767b
Cr-Commit-Position: refs/heads/master@{#363458}