pdf/pdfium/pdfium_engine.cc - Issue 1491083002: Set V8 extras mode in gin::V8Initializer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pdf/pdfium/pdfium_engine.cc

Issue 1491083002: Set V8 extras mode in gin::V8Initializer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pdf/pdfium/pdfium_engine.cc

diff --git a/pdf/pdfium/pdfium_engine.cc b/pdf/pdfium/pdfium_engine.cc

index 8fd5afb36dbba0a5d791d1b0950ee36731c1f994..20e84d9211b24c10fca038d77a0652d6603b03e8 100644

--- a/pdf/pdfium/pdfium_engine.cc

+++ b/pdf/pdfium/pdfium_engine.cc

@@ -455,6 +455,7 @@ gin::IsolateHolder* g_isolate_holder = nullptr;

void SetUpV8() {

gin::IsolateHolder::Initialize(gin::IsolateHolder::kNonStrictMode,

+ gin::IsolateHolder::kStableV8Extras,

gin::ArrayBufferAllocator::SharedInstance());

g_isolate_holder =

new gin::IsolateHolder(gin::IsolateHolder::kSingleThread);