Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 1491013005: Revert of DirectRenderer allows empty swap rects for CommitOverlayPlanes (Closed)

Created:
5 years ago by watk
Modified:
5 years ago
Reviewers:
ccameron, piman
CC:
chromium-reviews, darin-cc_chromium.org, cc-bugs_chromium.org, jam, kalyank_
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of DirectRenderer allows empty swap rects for CommitOverlayPlanes (patchset #3 id:40001 of https://codereview.chromium.org/1489153002/ ) Reason for revert: This probably broken the msan bots, e.g., https://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20ChromeOS%20MSan%20Tests/builds/5701 Original issue's description: > DirectRenderer allows empty swap rects for CommitOverlayPlanes > > Previously DirectRenderer would expand the damage rect to the full > output when partial swap buffers was not supported, because it had to > swap the whole buffer. Now, with the availability of CommitOverlayPlanes > it's possible that the surface has capability "allow_empty_swap", which > means swapping an empty rect is valid regardless of whether partial > swap is available. The surface is responsible for translating an empty > swap rect into a call to CommitOverlayPlanes. > > BUG=533630 > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > > Committed: https://crrev.com/581da2687c9e3031d07f2e0c28e32283b9b3e770 > Cr-Commit-Position: refs/heads/master@{#362812} TBR=ccameron@chromium.org,piman@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=533630 Committed: https://crrev.com/7de58fedbbfc8bb4a2bd8ab92dc4ebffc31987f6 Cr-Commit-Position: refs/heads/master@{#363077} CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -69 lines) Patch
M cc/output/direct_renderer.cc View 3 chunks +6 lines, -12 lines 0 comments Download
M cc/output/gl_renderer.cc View 2 chunks +4 lines, -9 lines 0 comments Download
M cc/output/overlay_unittest.cc View 2 chunks +1 line, -35 lines 0 comments Download
M cc/output/renderer.h View 1 chunk +0 lines, -3 lines 0 comments Download
M cc/test/test_web_graphics_context_3d.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/renderer_host/compositor_impl_android.cc View 1 chunk +3 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
watk
Created Revert of DirectRenderer allows empty swap rects for CommitOverlayPlanes
5 years ago (2015-12-03 22:38:40 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1491013005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1491013005/1
5 years ago (2015-12-03 22:39:21 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-03 22:41:59 UTC) #3
commit-bot: I haz the power
5 years ago (2015-12-03 22:42:54 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7de58fedbbfc8bb4a2bd8ab92dc4ebffc31987f6
Cr-Commit-Position: refs/heads/master@{#363077}

Powered by Google App Engine
This is Rietveld 408576698