Remove HTMLFormControlElement::m_disabled, m_isReadOnly, and m_isRequired.

Remove HTMLFormControlElement::m_disabled, m_isReadOnly, and m_isRequired.

We don't need to keep them because parseAttribute knows their old values.

BUG=561251
Committed: https://crrev.com/70e269230aae5a9d299813492f76828615c284e9
Cr-Commit-Position: refs/heads/master@{#362914}

[tkent, 2015-12-03 02:11:30]

Patchset #1 (id:1) has been deleted

[tkent, 2015-12-03 02:12:26]

Description was changed from

==========
Simplify Elemenet::parseAttribute and attributeChanged overrides.

Work-in-progress

BUG=561251
==========

to

==========
Remove HTMLFormControlElement::m_disabled, m_isReadOnly, and m_isRequired.

We don't need to keep them because parseAttribute knows their old values.

BUG=561251
==========

[tkent, 2015-12-03 03:25:58]

tkent@chromium.org changed reviewers:
+ kochi@chromium.org

[tkent, 2015-12-03 03:25:59]

kochi-san, would you review this please?

[kochi, 2015-12-03 03:38:59]

https://codereview.chromium.org/1490973002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/HTMLFormControlElement.h (right):

https://codereview.chromium.org/1490973002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/HTMLFormControlElement.h:103: bool
isReadOnly() const { return fastHasAttribute(HTMLNames::readonlyAttr); }
isRequired() is just { return fastHasAttribute(...); } but defined out-of-line.
If not performance critical, how about making them consistent (both inline, or
both out-of-line)?

https://codereview.chromium.org/1490973002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/HTMLFormControlElement.h:177: bool
m_isAutofilled : 1;
Can these 2 bitfields move to below so that it could be grouped as
one integer (skipping 2 enum members below) to get the class smaller?

[tkent, 2015-12-03 04:05:29]

I updated the patch.

https://codereview.chromium.org/1490973002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/HTMLFormControlElement.h (right):

https://codereview.chromium.org/1490973002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/HTMLFormControlElement.h:103: bool
isReadOnly() const { return fastHasAttribute(HTMLNames::readonlyAttr); }
On 2015/12/03 at 03:38:59, kochi wrote:
> isRequired() is just { return fastHasAttribute(...); } but defined
out-of-line.
> If not performance critical, how about making them consistent (both inline, or
> both out-of-line)?

Ok, I took out-of-line.

https://codereview.chromium.org/1490973002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/HTMLFormControlElement.h:177: bool
m_isAutofilled : 1;
On 2015/12/03 at 03:38:59, kochi wrote:
> Can these 2 bitfields move to below so that it could be grouped as
> one integer (skipping 2 enum members below) to get the class smaller?

Good suggestion.  Done.

[kochi, 2015-12-03 04:11:44]

lgtm

[tkent, 2015-12-03 04:18:00]

Thank you!

[tkent, 2015-12-03 04:18:03]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2015-12-03 04:19:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1490973002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1490973002/40001

[commit-bot: I haz the power, 2015-12-03 05:20:58]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2015-12-03 05:23:38]

Description was changed from

==========
Remove HTMLFormControlElement::m_disabled, m_isReadOnly, and m_isRequired.

We don't need to keep them because parseAttribute knows their old values.

BUG=561251
==========

to

==========
Remove HTMLFormControlElement::m_disabled, m_isReadOnly, and m_isRequired.

We don't need to keep them because parseAttribute knows their old values.

BUG=561251

Committed: https://crrev.com/70e269230aae5a9d299813492f76828615c284e9
Cr-Commit-Position: refs/heads/master@{#362914}
==========

[commit-bot: I haz the power, 2015-12-03 05:23:39]

Patchset 2 (id:??) landed as
https://crrev.com/70e269230aae5a9d299813492f76828615c284e9
Cr-Commit-Position: refs/heads/master@{#362914}