Remove HTMLFormControlElement::m_disabled, m_isReadOnly, and m_isRequired.

third_party/WebKit/Source/core/html/HTMLFormControlElement.h

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2000 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
@@ skipping 82 matching lines @@
     void hideVisibleValidationMessage();
     bool checkValidity(WillBeHeapVector<RefPtrWillBeMember<HTMLFormControlElement>>* unhandledInvalidControls = 0, CheckValidityEventBehavior = CheckValidityDispatchInvalidEvent);
     bool reportValidity();
     // This must be called only after the caller check the element is focusable.
     void showValidationMessage();
     // This must be called when a validation constraint or control value is changed.
     void setNeedsValidityCheck();
     void setCustomValidity(const String&) final;
     void findCustomValidationMessageTextDirection(const String& message, TextDirection &messageDir, String& subMessage, TextDirection& subMessageDir);
 
-    bool isReadOnly() const { return m_isReadOnly; }
-    bool isDisabledOrReadOnly() const { return isDisabledFormControl() || m_isReadOnly; }
+    bool isReadOnly() const { return fastHasAttribute(HTMLNames::readonlyAttr); }

[kochi, 2015/12/03 03:38:59]

isRequired() is just { return fastHasAttribute(...); } but defined out-of-line.
If not performance critical, how about making them consistent (both inline, or
both out-of-line)?

[tkent, 2015/12/03 04:05:29]

Ok, I took out-of-line.

+    bool isDisabledOrReadOnly() const { return isDisabledFormControl() || isReadOnly(); }
 
     bool isAutofocusable() const;
 
     bool isAutofilled() const { return m_isAutofilled; }
     void setAutofilled(bool = true);
 
     static HTMLFormControlElement* enclosingFormControlElement(Node*);
 
     String nameForAutofill() const;
 
@@ skipping 52 matching lines @@
     void updateAncestorDisabledState() const;
 
     bool isValidationMessageVisible() const;
     ValidationMessageClient* validationMessageClient() const;
 
     // Requests validity recalc for the form owner, if one exists.
     void formOwnerSetNeedsValidityCheck();
     // Requests validity recalc for all ancestor fieldsets, if exist.
     void fieldSetAncestorsSetNeedsValidityCheck(Node*);
 
-    bool m_disabled : 1;
     bool m_isAutofilled : 1;

[kochi, 2015/12/03 03:38:59]

Can these 2 bitfields move to below so that it could be grouped as
one integer (skipping 2 enum members below) to get the class smaller?

[tkent, 2015/12/03 04:05:29]

Good suggestion.  Done.

-    bool m_isReadOnly : 1;
-    bool m_isRequired : 1;
     bool m_hasValidationMessage : 1;
 
     enum AncestorDisabledState { AncestorDisabledStateUnknown, AncestorDisabledStateEnabled, AncestorDisabledStateDisabled };
     mutable AncestorDisabledState m_ancestorDisabledState;
     enum DataListAncestorState { Unknown, InsideDataList, NotInsideDataList };
     mutable enum DataListAncestorState m_dataListAncestorState;
 
     // The initial value of m_willValidate depends on the derived class. We can't
     // initialize it with a virtual function in the constructor. m_willValidate
     // is not deterministic as long as m_willValidateInitialized is false.
@@ skipping 12 matching lines @@
 {
     return element.isFormControlElement();
 }
 
 DEFINE_HTMLELEMENT_TYPE_CASTS_WITH_FUNCTION(HTMLFormControlElement);
 DEFINE_TYPE_CASTS(HTMLFormControlElement, FormAssociatedElement, control, control->isFormControlElement(), control.isFormControlElement());
 
 } // namespace
 
 #endif