Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 149073009: Remove InputMethodTSF, TSFEventRouter, TSFTextStore, TSFBridge (Closed)

Created:
6 years, 10 months ago by scottmg
Modified:
6 years, 10 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, tfarina, penghuang+watch_chromium.org, nona+watch_chromium.org, ben+views_chromium.org, James Su, msw
Visibility:
Public.

Description

Remove InputMethodTSF, TSFEventRouter, TSFTextStore, TSFBridge My understanding is that these are now unnecessary. Hopefully I haven't removed too much here. TBR=ben@chromium.org R=yukawa@chromium.org BUG=319122, 5027, 330735 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248001

Patch Set 1 #

Patch Set 2 : . #

Total comments: 2

Patch Set 3 : revert input_method_imm32 changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4010 lines) Patch
M ui/base/ime/ime.gypi View 3 chunks +0 lines, -10 lines 0 comments Download
M ui/base/ime/ime_test_support.gypi View 1 chunk +0 lines, -10 lines 0 comments Download
M ui/base/ime/ime_unittests.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
M ui/base/ime/input_method_factory.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M ui/base/ime/input_method_initializer.cc View 5 chunks +0 lines, -16 lines 0 comments Download
D ui/base/ime/input_method_tsf.h View 1 chunk +0 lines, -58 lines 0 comments Download
D ui/base/ime/input_method_tsf.cc View 1 chunk +0 lines, -158 lines 0 comments Download
D ui/base/ime/win/mock_tsf_bridge.h View 1 chunk +0 lines, -100 lines 0 comments Download
D ui/base/ime/win/mock_tsf_bridge.cc View 1 chunk +0 lines, -83 lines 0 comments Download
D ui/base/ime/win/tsf_bridge.h View 1 chunk +0 lines, -97 lines 0 comments Download
D ui/base/ime/win/tsf_bridge.cc View 1 chunk +0 lines, -558 lines 0 comments Download
D ui/base/ime/win/tsf_event_router.h View 1 chunk +0 lines, -81 lines 0 comments Download
D ui/base/ime/win/tsf_event_router.cc View 1 chunk +0 lines, -307 lines 0 comments Download
D ui/base/ime/win/tsf_text_store.h View 1 chunk +0 lines, -297 lines 0 comments Download
D ui/base/ime/win/tsf_text_store.cc View 1 chunk +0 lines, -924 lines 0 comments Download
D ui/base/ime/win/tsf_text_store_unittest.cc View 1 chunk +0 lines, -1304 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_root_window_host_win.cc View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
scottmg
6 years, 10 months ago (2014-01-30 00:14:27 UTC) #1
scottmg
(oh, I wasn't sure if you were still actively working on chromium CLs, but I ...
6 years, 10 months ago (2014-01-30 03:25:48 UTC) #2
yukawa
Oh, thank you for making this CL. LGTM for ui/base/ime/* supposing ui/base/ime/input_method_imm32.cc is removed from ...
6 years, 10 months ago (2014-01-30 03:56:08 UTC) #3
scottmg
https://codereview.chromium.org/149073009/diff/20001/ui/base/ime/input_method_imm32.cc File ui/base/ime/input_method_imm32.cc (left): https://codereview.chromium.org/149073009/diff/20001/ui/base/ime/input_method_imm32.cc#oldcode295 ui/base/ime/input_method_imm32.cc:295: tsf_inputscope::SetInputScopeForTsfUnawareWindow( On 2014/01/30 03:56:09, yukawa wrote: > Could you ...
6 years, 10 months ago (2014-01-30 04:18:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/149073009/40001
6 years, 10 months ago (2014-01-30 04:22:27 UTC) #5
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=47152
6 years, 10 months ago (2014-01-30 05:00:14 UTC) #6
scottmg
tbr ben for ui/views/widget/desktop_aura removal
6 years, 10 months ago (2014-01-30 05:25:48 UTC) #7
scottmg
tbr ben for ui/views/widget/desktop_aura removal
6 years, 10 months ago (2014-01-30 05:26:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/149073009/40001
6 years, 10 months ago (2014-01-30 05:27:02 UTC) #9
Ben Goodger (Google)
lgtm
6 years, 10 months ago (2014-01-30 05:36:00 UTC) #10
commit-bot: I haz the power
Retried try job too often on android_dbg for step(s) slave_steps http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_dbg&number=144578
6 years, 10 months ago (2014-01-30 07:36:25 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/149073009/40001
6 years, 10 months ago (2014-01-30 17:17:33 UTC) #12
commit-bot: I haz the power
Change committed as 248001
6 years, 10 months ago (2014-01-30 18:31:06 UTC) #13
commit-bot: I haz the power
6 years, 10 months ago (2014-01-30 18:31:13 UTC) #14
Message was sent while issue was closed. 
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698