Revert of Reland: Crashpad Windows: Use the Crashpad client instead of Breakpad on Windows

Revert of Reland: Crashpad Windows: Use the Crashpad client instead of Breakpad on Windows (patchset #4 id:100001 of https://codereview.chromium.org/1479283002/ )

Reason for revert:
Breaks Win x64 GN compile : http://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN?numbuilds=200

(sad that this bot doesn't have a CQ counterpart...)

Log for posterity:
<snip>
(...)
[3226/6095] STAMP obj/chrome/common/common.inputdeps.stamp
[3227/6095] STAMP obj/components/update_client/unit_tests.inputdeps.stamp
[3228/6095] CXX obj/chrome/common/common/child_process_logging_win.obj
[3229/6095] CXX obj/chrome/common/common/chrome_content_client.obj
FAILED: E:/b/depot_tools/python276_bin/python.exe gyp-win-tool link-wrapper environment.x64 False link.exe /nologo /OUT:setup_unittests.exe /PDB:setup_unittests.exe.pdb @setup_unittests.exe.rsp
breakpad_win.obj :error LNK2005: CrashForException already defined in crashpad_win.obj

breakpad_win.obj :error LNK2005: RegisterNonABICompliantCodeRange already defined in crashpad_win.obj

breakpad_win.obj :error LNK2005: UnregisterNonABICompliantCodeRange already defined in crashpad_win.obj

setup_unittests.exe : fatalerror LNK1169: one or more multiply defined symbols found
</snip>


Original issue's description:
> Reland: Crashpad Windows: Use the Crashpad client instead of Breakpad on Windows
> 
> Changes since https://codereview.chromium.org/1416133003 are ps1 -> ps2.
> 
> - Includes build fix to for debug component GN build.
> - Includes Crashpad roll to pull in clang compile fixes and a limit on
> the number of locks saved to the crash dump.
> - Increase timeout on tab crash telemetry test for debug builds.
> 
> Original CL:
> Crashpad Windows: Use the Crashpad client instead of Breakpad on Windows
> 
> Crashpad is always compiled into chrome and its handler is always
> enabled. It only uploads in Official builds.
> 
> On Windows, the crash handler is chrome.exe run with a
> --crashpad-handler argument. This is due to concern about
> incompatibilities of shipping an additional new different binary for AV,
> firewalls, etc.
> 
> Sample renderer crash/1aed2bc785e28995
> Sample browser: crash/66c822815474a5d8
> 
> See also http://crbug.com/427611 .
> 
> R=mark@chromium.org
> TBR=cpu@chromium.org
> BUG=447073, 546288, 456193
> 
> Committed: https://crrev.com/cfa5b01bb1d06bf96967bd37e21a44752801948c
> Cr-Commit-Position: refs/heads/master@{#362258}

TBR=cpu@chromium.org,mark@chromium.org,scottmg@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=447073, 546288, 456193

[gab, 2015-12-01 15:26:31]

Created Revert of Reland: Crashpad Windows: Use the Crashpad client instead of
Breakpad on Windows

[commit-bot: I haz the power, 2015-12-01 15:27:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1490613004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1490613004/1

[gab, 2015-12-01 15:27:41]

Description was changed from

==========
Revert of Reland: Crashpad Windows: Use the Crashpad client instead of Breakpad
on Windows (patchset #4 id:100001 of https://codereview.chromium.org/1479283002/
)

Reason for revert:
Breaks Win x64 GN compile :
http://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN?numbuilds=200

(sad that this bot doesn't have a CQ counterpart...)

Original issue's description:
> Reland: Crashpad Windows: Use the Crashpad client instead of Breakpad on
Windows
> 
> Changes since https://codereview.chromium.org/1416133003 are ps1 -> ps2.
> 
> - Includes build fix to for debug component GN build.
> - Includes Crashpad roll to pull in clang compile fixes and a limit on
> the number of locks saved to the crash dump.
> - Increase timeout on tab crash telemetry test for debug builds.
> 
> Original CL:
> Crashpad Windows: Use the Crashpad client instead of Breakpad on Windows
> 
> Crashpad is always compiled into chrome and its handler is always
> enabled. It only uploads in Official builds.
> 
> On Windows, the crash handler is chrome.exe run with a
> --crashpad-handler argument. This is due to concern about
> incompatibilities of shipping an additional new different binary for AV,
> firewalls, etc.
> 
> Sample renderer crash/1aed2bc785e28995
> Sample browser: crash/66c822815474a5d8
> 
> See also http://crbug.com/427611 .
> 
> R=mark@chromium.org
> TBR=cpu@chromium.org
> BUG=447073, 546288, 456193
> 
> Committed: https://crrev.com/cfa5b01bb1d06bf96967bd37e21a44752801948c
> Cr-Commit-Position: refs/heads/master@{#362258}

TBR=cpu@chromium.org,mark@chromium.org,scottmg@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=447073, 546288, 456193
==========

to

==========
Revert of Reland: Crashpad Windows: Use the Crashpad client instead of Breakpad
on Windows (patchset #4 id:100001 of https://codereview.chromium.org/1479283002/
)

Reason for revert:
Breaks Win x64 GN compile :
http://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN?numbuilds=200

(sad that this bot doesn't have a CQ counterpart...)

Log for posterity:
<snip>
(...)
[3226/6095] STAMP obj/chrome/common/common.inputdeps.stamp
[3227/6095] STAMP obj/components/update_client/unit_tests.inputdeps.stamp
[3228/6095] CXX obj/chrome/common/common/child_process_logging_win.obj
[3229/6095] CXX obj/chrome/common/common/chrome_content_client.obj
FAILED: E:/b/depot_tools/python276_bin/python.exe gyp-win-tool link-wrapper
environment.x64 False link.exe /nologo /OUT:setup_unittests.exe
/PDB:setup_unittests.exe.pdb @setup_unittests.exe.rsp
breakpad_win.obj :error LNK2005: CrashForException already defined in
crashpad_win.obj

breakpad_win.obj :error LNK2005: RegisterNonABICompliantCodeRange already
defined in crashpad_win.obj

breakpad_win.obj :error LNK2005: UnregisterNonABICompliantCodeRange already
defined in crashpad_win.obj

setup_unittests.exe : fatalerror LNK1169: one or more multiply defined symbols
found
</snip>


Original issue's description:
> Reland: Crashpad Windows: Use the Crashpad client instead of Breakpad on
Windows
> 
> Changes since https://codereview.chromium.org/1416133003 are ps1 -> ps2.
> 
> - Includes build fix to for debug component GN build.
> - Includes Crashpad roll to pull in clang compile fixes and a limit on
> the number of locks saved to the crash dump.
> - Increase timeout on tab crash telemetry test for debug builds.
> 
> Original CL:
> Crashpad Windows: Use the Crashpad client instead of Breakpad on Windows
> 
> Crashpad is always compiled into chrome and its handler is always
> enabled. It only uploads in Official builds.
> 
> On Windows, the crash handler is chrome.exe run with a
> --crashpad-handler argument. This is due to concern about
> incompatibilities of shipping an additional new different binary for AV,
> firewalls, etc.
> 
> Sample renderer crash/1aed2bc785e28995
> Sample browser: crash/66c822815474a5d8
> 
> See also http://crbug.com/427611 .
> 
> R=mark@chromium.org
> TBR=cpu@chromium.org
> BUG=447073, 546288, 456193
> 
> Committed: https://crrev.com/cfa5b01bb1d06bf96967bd37e21a44752801948c
> Cr-Commit-Position: refs/heads/master@{#362258}

TBR=cpu@chromium.org,mark@chromium.org,scottmg@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=447073, 546288, 456193
==========

[gab, 2015-12-01 15:27:50]

The CQ bit was unchecked by gab@chromium.org

[gab, 2015-12-01 15:27:53]

The CQ bit was checked by gab@chromium.org

[commit-bot: I haz the power, 2015-12-01 15:28:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-01 15:28:20]

Failed to apply patch for DEPS:
While running git apply --index -3 -p1;
  error: patch failed: DEPS:127
  error: repository lacks the necessary blob to fall back on 3-way merge.
  error: DEPS: patch does not apply

Patch:       DEPS
Index: DEPS
diff --git a/DEPS b/DEPS
index
01076920a03cb620ad7f88040465bd6817f567f9..8f86ee1b7576cc0bcc309859818d9381eb0da56a
100644
--- a/DEPS
+++ b/DEPS
@@ -127,7 +127,7 @@
    Var('chromium_git') + '/external/colorama.git' + '@' +
'799604a1041e9b3bc5d2789ecbd7e8db2e18e6b8',
 
   'src/third_party/crashpad/crashpad':
-   Var('chromium_git') + '/crashpad/crashpad.git' + '@' +
'1f3ced1846f3956e678c562c90e0d6c970543617',
+   Var('chromium_git') + '/crashpad/crashpad.git' + '@' +
'97b0f86d0ccb095391ca64b3948f0d6c02975ac1',
 
   'src/third_party/icu':
    Var('chromium_git') + '/chromium/deps/icu.git' + '@' +
'42c58d4e49f2250039f0e98d43e0b76e8f5ca024',

[commit-bot: I haz the power, 2015-12-01 15:28:59]

The CQ bit was unchecked by commit-bot@chromium.org

[Mark Mentovai, 2015-12-01 15:32:51]

Looks like we can just remove the Breakpad file from the Windows x86_64 gn
build. That might be easier than unwinding what’s landed on top of this.

[scottmg, 2015-12-01 15:50:20]

Taking a look now...

[scottmg, 2015-12-01 16:02:16]

On 2015/12/01 15:50:20, scottmg wrote:
> Taking a look now...

Fix here: https://codereview.chromium.org/1485163002

[scottmg, 2015-12-01 16:05:24]

On 2015/12/01 16:02:16, scottmg wrote:
> On 2015/12/01 15:50:20, scottmg wrote:
> > Taking a look now...
> 
> Fix here: https://codereview.chromium.org/1485163002

Fix has landed, I'll keep an eye on the GN bots, and close this one.