Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 1485163002: win: fix x64 gn static build (Closed)

Created:
5 years ago by scottmg
Modified:
5 years ago
Reviewers:
Mark Mentovai, gab
CC:
chromium-reviews, grt+watch_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

win: fix x64 gn static build setup.exe isn't converted to crashpad yet, and still uses breakpad. Tested gn gen out/gn --args="is_debug=false is_component_build=false symbol_level=1 target_cpu=\"x86\"" --check and gn gen out/gn --args="is_debug=false is_component_build=false symbol_level=1" --check building ninja -C out/gn chrome/installer/setup:setup R=mark@chromium.org, gab@chromium.org BUG=546288 Committed: https://chromium.googlesource.com/chromium/src/+/965a7a3b0ccaa7ca036d3e7d484b7754b3785818

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M chrome/installer/setup/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
scottmg
5 years ago (2015-12-01 16:02:23 UTC) #1
Mark Mentovai
LGTM
5 years ago (2015-12-01 16:02:42 UTC) #2
scottmg
Not going to bother with trybots since the original change "passed" anyway.
5 years ago (2015-12-01 16:03:22 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/965a7a3b0ccaa7ca036d3e7d484b7754b3785818 Cr-Commit-Position: refs/heads/master@{#362417}
5 years ago (2015-12-01 16:06:31 UTC) #6
scottmg
5 years ago (2015-12-01 16:07:05 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
965a7a3b0ccaa7ca036d3e7d484b7754b3785818 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698