Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 1490533002: Merge M48: "Ensure both default audio device IDs are handled for creation." (Closed)

Created:
5 years ago by DaleCurtis
Modified:
5 years ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2564
Target Ref:
refs/pending/branch-heads/2564
Project:
chromium
Visibility:
Public.

Description

Merge M48: "Ensure both default audio device IDs are handled for creation." With the introduction of the AudioOutputDeviceEnumerator we started creating AudioOutputControllers with kDefaultDeviceId, but the proxy creation code did not merge these cases correctly -- so streams which should have been default were stuck on a single device. This adds a test for this behavior, though it unfortunately relies on some internal AudioManager details -- we've seen similar bugs like this in the past, so its clear we need something. BUG=557620 TEST=switched headphones works, new unittest. Review URL: https://codereview.chromium.org/1480523004 Cr-Commit-Position: refs/heads/master@{#361875} (cherry picked from commit 6543b17d2aa62107125c34ec2550fd46181c316e) Committed: https://chromium.googlesource.com/chromium/src/+/e1dbf162c1c043f4bb6f0bf77d99076837da33c5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -3 lines) Patch
M media/audio/audio_manager_base.cc View 3 chunks +7 lines, -3 lines 0 comments Download
M media/audio/audio_manager_unittest.cc View 3 chunks +41 lines, -0 lines 0 comments Download
M media/audio/audio_output_proxy.h View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
DaleCurtis
5 years ago (2015-11-30 19:49:32 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e1dbf162c1c043f4bb6f0bf77d99076837da33c5.

Powered by Google App Engine
This is Rietveld 408576698