Ensure both default audio device IDs are handled for creation.

Ensure both default audio device IDs are handled for creation.

With the introduction of the AudioOutputDeviceEnumerator we started
creating AudioOutputControllers with kDefaultDeviceId, but the proxy
creation code did not merge these cases correctly -- so streams
which should have been default were stuck on a single device.

This adds a test for this behavior, though it unfortunately relies
on some internal AudioManager details -- we've seen similar bugs
like this in the past, so its clear we need something.

BUG=557620
TEST=switched headphones works, new unittest.

Committed: https://crrev.com/6543b17d2aa62107125c34ec2550fd46181c316e
Cr-Commit-Position: refs/heads/master@{#361875}

[DaleCurtis, 2015-11-25 20:16:42]

dalecurtis@chromium.org changed reviewers:
+ guidou@chromium.org, tommi@chromium.org

[DaleCurtis, 2015-11-25 20:16:43]

Please CQ if this looks good to you since I'll be OOO for turkey days.

+tommi as well since guidou@ doesn't have the magic committer bit yet :(

[Guido Urdaneta, 2015-11-25 20:44:44]

lgtm

[tommi (sloooow) - chröme, 2015-11-26 00:07:05]

The CQ bit was checked by tommi@chromium.org

[tommi (sloooow) - chröme, 2015-11-26 00:07:05]

lgtm

[commit-bot: I haz the power, 2015-11-26 00:09:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1480523004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1480523004/20001

[commit-bot: I haz the power, 2015-11-26 00:42:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-26 00:42:16]

Try jobs failed on following builders:
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[DaleCurtis, 2015-11-26 01:16:18]

Thanks for review, moved test to run on AudioThread (man, it's high time we had
an injectable task runner for CreateForTesting!)

[DaleCurtis, 2015-11-26 01:16:37]

The CQ bit was checked by dalecurtis@chromium.org

[DaleCurtis, 2015-11-26 01:16:37]

The patchset sent to the CQ was uploaded after l-g-t-m from guidou@chromium.org,
tommi@chromium.org
Link to the patchset: https://codereview.chromium.org/1480523004/#ps40001
(title: "Fix test.")

[commit-bot: I haz the power, 2015-11-26 01:17:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1480523004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1480523004/40001

[commit-bot: I haz the power, 2015-11-26 03:20:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-26 03:20:38]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_TIMED_OUT, no build
URL)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL)

[Guido Urdaneta, 2015-11-26 12:57:36]

The CQ bit was checked by guidou@chromium.org

[commit-bot: I haz the power, 2015-11-26 12:57:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1480523004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1480523004/40001

[commit-bot: I haz the power, 2015-11-26 13:02:58]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-11-26 13:04:15]

Description was changed from

==========
Ensure both default audio device IDs are handled for creation.

With the introduction of the AudioOutputDeviceEnumerator we started
creating AudioOutputControllers with kDefaultDeviceId, but the proxy
creation code did not merge these cases correctly -- so streams
which should have been default were stuck on a single device.

This adds a test for this behavior, though it unfortunately relies
on some internal AudioManager details -- we've seen similar bugs
like this in the past, so its clear we need something.

BUG=557620
TEST=switched headphones works, new unittest.
==========

to

==========
Ensure both default audio device IDs are handled for creation.

With the introduction of the AudioOutputDeviceEnumerator we started
creating AudioOutputControllers with kDefaultDeviceId, but the proxy
creation code did not merge these cases correctly -- so streams
which should have been default were stuck on a single device.

This adds a test for this behavior, though it unfortunately relies
on some internal AudioManager details -- we've seen similar bugs
like this in the past, so its clear we need something.

BUG=557620
TEST=switched headphones works, new unittest.

Committed: https://crrev.com/6543b17d2aa62107125c34ec2550fd46181c316e
Cr-Commit-Position: refs/heads/master@{#361875}
==========

[commit-bot: I haz the power, 2015-11-26 13:04:15]

Patchset 3 (id:??) landed as
https://crrev.com/6543b17d2aa62107125c34ec2550fd46181c316e
Cr-Commit-Position: refs/heads/master@{#361875}