MD Settings: Adding unit test for ResetSettingsHandler.

chrome/browser/profile_resetter/profile_resetter.h

Index: chrome/browser/profile_resetter/profile_resetter.h
diff --git a/chrome/browser/profile_resetter/profile_resetter.h b/chrome/browser/profile_resetter/profile_resetter.h
index 31f92cd58ea7471d8f49cc8a3003b31bbc35b4be..e230a15beb0e4b3bbf311476729662c74085ba39 100644
--- a/chrome/browser/profile_resetter/profile_resetter.h
+++ b/chrome/browser/profile_resetter/profile_resetter.h
@@ -61,11 +61,11 @@ class ProfileResetter : public base::NonThreadSafe,
   // Resets |resettable_flags| and calls |callback| on the UI thread on
   // completion. |default_settings| allows the caller to specify some default
   // settings. |default_settings| shouldn't be NULL.
-  void Reset(ResettableFlags resettable_flags,
-             scoped_ptr<BrandcodedDefaultSettings> master_settings,
-             const base::Closure& callback);
+  virtual void Reset(ResettableFlags resettable_flags,
+                     scoped_ptr<BrandcodedDefaultSettings> master_settings,
+                     const base::Closure& callback);
 
-  bool IsActive() const;
+  virtual bool IsActive() const;

[battre, 2015/12/01 09:55:19]

Why do you make these virtual? I don't see them mocked or overridden anywhere.

[engedy, 2015/12/01 10:22:25]

They seem to be overridden by the mock in the unittest.  Adding tests for WebUI
handlers is something I've been looking forward to for a long time, so I
personally very much welcome this change.

 
  private:
   // Marks |resettable| as done and triggers |callback_| if all pending jobs