MD Settings: Adding unit test for ResetSettingsHandler.

chrome/browser/profile_resetter/profile_resetter.h

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_PROFILE_RESETTER_PROFILE_RESETTER_H_
 #define CHROME_BROWSER_PROFILE_RESETTER_PROFILE_RESETTER_H_
 
 #include <utility>
 #include <vector>
 
@@ skipping 43 matching lines @@
 
   static_assert(sizeof(ResettableFlags) == sizeof(Resettable),
                 "ResettableFlags should be the same size as Resettable");
 
   explicit ProfileResetter(Profile* profile);
   ~ProfileResetter() override;
 
   // Resets |resettable_flags| and calls |callback| on the UI thread on
   // completion. |default_settings| allows the caller to specify some default
   // settings. |default_settings| shouldn't be NULL.
-  void Reset(ResettableFlags resettable_flags,
-             scoped_ptr<BrandcodedDefaultSettings> master_settings,
-             const base::Closure& callback);
+  virtual void Reset(ResettableFlags resettable_flags,
+                     scoped_ptr<BrandcodedDefaultSettings> master_settings,
+                     const base::Closure& callback);
 
-  bool IsActive() const;
+  virtual bool IsActive() const;

[battre, 2015/12/01 09:55:19]

Why do you make these virtual? I don't see them mocked or overridden anywhere.

[engedy, 2015/12/01 10:22:25]

They seem to be overridden by the mock in the unittest.  Adding tests for WebUI
handlers is something I've been looking forward to for a long time, so I
personally very much welcome this change.

 
  private:
   // Marks |resettable| as done and triggers |callback_| if all pending jobs
   // have completed.
   void MarkAsDone(Resettable resettable);
 
   void ResetDefaultSearchEngine();
   void ResetHomepage();
   void ResetContentSettings();
   void ResetCookiesAndSiteData();
@@ skipping 35 matching lines @@
 
 typedef base::RefCountedData<base::CancellationFlag> SharedCancellationFlag;
 
 // On Windows returns all the shortcuts which launch Chrome and corresponding
 // arguments. |cancel| can be passed to abort the operation earlier.
 // Call on FILE thread.
 std::vector<ShortcutCommand> GetChromeLaunchShortcuts(
     const scoped_refptr<SharedCancellationFlag>& cancel);
 
 #endif  // CHROME_BROWSER_PROFILE_RESETTER_PROFILE_RESETTER_H_