Issue 1490463003: Don't use ".catch" in dart2js generated code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1490463003: Don't use ".catch" in dart2js generated code. (Closed)

Created:
5 years ago by floitsch

Modified:
5 years ago

Reviewers:
sra1

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Don't use ".catch" in dart2js generated code. "catch" as a property name is legal in most VMs nowadays, but a few implementations still don't like it. R=sra@google.com Committed: https://github.com/dart-lang/sdk/commit/74d2846cb53be205463f2dc55d3d7ccfc882b3d2

Created: 5 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	pkg/js_ast/lib/src/printer.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	sdk/lib/html/html_common/conversions_dart2js.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (2 generated)

floitsch

5 years ago (2015-12-01 00:54:42 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
74d2846cb53be205463f2dc55d3d7ccfc882b3d2 (presubmit successful).